-
Notifications
You must be signed in to change notification settings - Fork 47k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[compiler][ez] Enable some sprout tests that no longer need to be dis…
…abled Summary: As title. Better support for flow typing, bugfixes, etc fixes these ghstack-source-id: 6326653ce42b33b6c1c76a494434d133382ca80a Pull Request resolved: #30591
- Loading branch information
Showing
5 changed files
with
62 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d7c12c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on refactoring the Foo and Bar components! The use of caching with the $ array in the Bar function is a clever optimization to avoid unnecessary re-renders. However, it might be helpful to add a brief comment explaining the purpose of the $ array for maintainability, especially for those who might be unfamiliar with this approach. Also, ensuring consistency in naming conventions could improve readability—for instance, keeping variable names like t0 and t1 more descriptive. Overall, the changes look solid and should enhance performance. Kudos!