Update

[ghstack-poisoned]
facebook · Jun 24, 2024 · 0fd3ef5 · 0fd3ef5
1 parent 3b3a5c8
commit 0fd3ef5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/runtime_build.yml b/.github/workflows/runtime_build.yml
@@ -54,13 +54,17 @@ jobs:
       - name: Archive build
         uses: actions/upload-artifact@v4
         with:
-          name: build-${{ matrix.release_channel }}-${{ matrix.bundle_type }}
+          name: ${{ matrix.bundle_type }}-${{ matrix.release_channel }}
           path: |
             build/**
 
   lint_build:
     name: yarn lint-build
     needs: [define_build_params, build]
+    strategy:
+      matrix:
+        bundle_type: ${{ fromJSON(needs.define_build_params.outputs.bundle_type) }}
+        release_channel: ${{ fromJSON(needs.define_build_params.outputs.release_channel) }}
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -78,6 +82,6 @@ jobs:
       - name: Restore archived build
         uses: actions/download-artifact@v4
         with:
-          name: build-${{ needs.define_build_params.outputs.release_channel }}-${{ needs.define_build_params.outputs.bundle_type }}
+          name: ${{ needs.define_build_params.outputs.bundle_type }}-${{ needs.define_build_params.outputs.release_channel }}
       - run: yarn install --frozen-lockfile
       - run: yarn lint-build
diff --git a/scripts/rollup/build-ghaction.js b/scripts/rollup/build-ghaction.js
@@ -845,10 +845,11 @@ async function buildEverything(bundleTypeToBuild) {
     ([, bundleType]) => bundleType === bundleTypeToBuild
   );
 
-  // eslint-disable-next-line no-for-of-loops/no-for-of-loops
-  for (const [bundle, bundleType] of bundles) {
-    await createBundle(bundle, bundleType);
-  }
+  await Promise.all(
+    bundles.map(([bundle, bundleType]) => {
+      return createBundle(bundle, bundleType);
+    })
+  );
 
   await Packaging.copyAllShims();
   await Packaging.prepareNpmPackages();