Skip to content

Commit

Permalink
[ci] Remove dep on build_devtools from run_devtools_e2e_tests
Browse files Browse the repository at this point in the history
The run_devtools_e2e_tests job does not appear to actually need anything
from the prior job since it always builds inline. Removing this dep
allows us to run both in parallel.

ghstack-source-id: dd5c3f3d5c0cae14ff60564253b54bf5eb785fff
Pull Request resolved: #30348
  • Loading branch information
poteto committed Jul 16, 2024
1 parent 804305a commit 3b6b900
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/runtime_build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ jobs:
uses: actions/download-artifact@v4
with:
path: build
pattern: build_*
merge-multiple: true
- name: Display structure of build
run: ls -R build
Expand Down Expand Up @@ -336,6 +337,7 @@ jobs:
uses: actions/download-artifact@v4
with:
path: build
pattern: build_*
merge-multiple: true
- run: ./scripts/circleci/pack_and_store_devtools_artifacts.sh
env:
Expand All @@ -361,7 +363,7 @@ jobs:

run_devtools_e2e_tests:
name: Run DevTools e2e tests
needs: build_devtools_and_process_artifacts
needs: build_and_lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -377,11 +379,6 @@ jobs:
path: "**/node_modules"
key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
- run: yarn install --frozen-lockfile
- name: Restore archived build
uses: actions/download-artifact@v4
with:
path: build
merge-multiple: true
- run: |
npx playwright install
sudo npx playwright install-deps
Expand Down

0 comments on commit 3b6b900

Please sign in to comment.