Skip to content

Commit

Permalink
Increase nested update limit to 100 (#31061)
Browse files Browse the repository at this point in the history
We're seeing the limit hit in some tests after enabling sibling
prerendering. Let's bump the limit so we can run more tests and gather
more signal on the changes. When we understand the scope of the problem
we can determine whether we need to change how the updates are counted
in prerenders and/or fix specific areas of product code.

DiffTrain build for [f9ebd85](f9ebd85)
  • Loading branch information
jackpope committed Sep 25, 2024
1 parent 97355e0 commit f148637
Show file tree
Hide file tree
Showing 34 changed files with 116 additions and 116 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@

f9ebd85a196948be17efdd6774b4d0464b3b1f53
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@

f9ebd85a196948be17efdd6774b4d0464b3b1f53
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2000,7 +2000,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-classic-04bd67a4-20240924";
exports.version = "19.0.0-www-classic-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1980,7 +1980,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-modern-04bd67a4-20240924";
exports.version = "19.0.0-www-modern-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-04bd67a4-20240924";
exports.version = "19.0.0-www-classic-f9ebd85a-20240925";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-04bd67a4-20240924";
exports.version = "19.0.0-www-modern-f9ebd85a-20240925";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-04bd67a4-20240924";
exports.version = "19.0.0-www-classic-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-04bd67a4-20240924";
exports.version = "19.0.0-www-modern-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16837,12 +16837,12 @@ __DEV__ &&
pendingPassiveEffectsLanes = 0,
pendingPassiveEffectsRemainingLanes = 0,
pendingPassiveTransitions = null,
NESTED_UPDATE_LIMIT = 50,
NESTED_UPDATE_LIMIT = 100,
nestedUpdateCount = 0,
rootWithNestedUpdates = null,
isFlushingPassiveEffects = !1,
didScheduleUpdateDuringPassiveEffects = !1,
NESTED_PASSIVE_UPDATE_LIMIT = 50,
NESTED_PASSIVE_UPDATE_LIMIT = 100,
nestedPassiveUpdateCount = 0,
rootWithPassiveNestedUpdates = null,
isRunningInsertionEffect = !1,
Expand Down Expand Up @@ -17072,11 +17072,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-classic-04bd67a4-20240924",
version: "19.0.0-www-classic-f9ebd85a-20240925",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-classic-f9ebd85a-20240925"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -17110,7 +17110,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-04bd67a4-20240924";
exports.version = "19.0.0-www-classic-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16284,12 +16284,12 @@ __DEV__ &&
pendingPassiveEffectsLanes = 0,
pendingPassiveEffectsRemainingLanes = 0,
pendingPassiveTransitions = null,
NESTED_UPDATE_LIMIT = 50,
NESTED_UPDATE_LIMIT = 100,
nestedUpdateCount = 0,
rootWithNestedUpdates = null,
isFlushingPassiveEffects = !1,
didScheduleUpdateDuringPassiveEffects = !1,
NESTED_PASSIVE_UPDATE_LIMIT = 50,
NESTED_PASSIVE_UPDATE_LIMIT = 100,
nestedPassiveUpdateCount = 0,
rootWithPassiveNestedUpdates = null,
isRunningInsertionEffect = !1,
Expand Down Expand Up @@ -16518,11 +16518,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-modern-04bd67a4-20240924",
version: "19.0.0-www-modern-f9ebd85a-20240925",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-modern-f9ebd85a-20240925"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16556,7 +16556,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-04bd67a4-20240924";
exports.version = "19.0.0-www-modern-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10321,7 +10321,7 @@ function resolveRetryWakeable(boundaryFiber, wakeable) {
retryTimedOutBoundary(boundaryFiber, retryLane);
}
function throwIfInfiniteUpdateLoopDetected() {
if (50 < nestedUpdateCount)
if (100 < nestedUpdateCount)
throw (
((nestedUpdateCount = 0),
(rootWithNestedUpdates = null),
Expand Down Expand Up @@ -10896,13 +10896,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1441 = {
bundleType: 0,
version: "19.0.0-www-classic-04bd67a4-20240924",
version: "19.0.0-www-classic-f9ebd85a-20240925",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-classic-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-classic-f9ebd85a-20240925"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1442 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10928,4 +10928,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-04bd67a4-20240924";
exports.version = "19.0.0-www-classic-f9ebd85a-20240925";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9878,7 +9878,7 @@ function resolveRetryWakeable(boundaryFiber, wakeable) {
retryTimedOutBoundary(boundaryFiber, retryLane);
}
function throwIfInfiniteUpdateLoopDetected() {
if (50 < nestedUpdateCount)
if (100 < nestedUpdateCount)
throw (
((nestedUpdateCount = 0),
(rootWithNestedUpdates = null),
Expand Down Expand Up @@ -10410,13 +10410,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1433 = {
bundleType: 0,
version: "19.0.0-www-modern-04bd67a4-20240924",
version: "19.0.0-www-modern-f9ebd85a-20240925",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-modern-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-modern-f9ebd85a-20240925"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1434 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10442,4 +10442,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-04bd67a4-20240924";
exports.version = "19.0.0-www-modern-f9ebd85a-20240925";
14 changes: 7 additions & 7 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -26985,12 +26985,12 @@ __DEV__ &&
pendingPassiveEffectsLanes = 0,
pendingPassiveEffectsRemainingLanes = 0,
pendingPassiveTransitions = null,
NESTED_UPDATE_LIMIT = 50,
NESTED_UPDATE_LIMIT = 100,
nestedUpdateCount = 0,
rootWithNestedUpdates = null,
isFlushingPassiveEffects = !1,
didScheduleUpdateDuringPassiveEffects = !1,
NESTED_PASSIVE_UPDATE_LIMIT = 50,
NESTED_PASSIVE_UPDATE_LIMIT = 100,
nestedPassiveUpdateCount = 0,
rootWithPassiveNestedUpdates = null,
isRunningInsertionEffect = !1,
Expand Down Expand Up @@ -27813,11 +27813,11 @@ __DEV__ &&
: flushSyncErrorInBuildsThatSupportLegacyMode;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-www-classic-04bd67a4-20240924" !== isomorphicReactPackageVersion)
if ("19.0.0-www-classic-f9ebd85a-20240925" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-www-classic-04bd67a4-20240924\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-www-classic-f9ebd85a-20240925\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -27861,11 +27861,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-classic-04bd67a4-20240924",
version: "19.0.0-www-classic-f9ebd85a-20240925",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-classic-f9ebd85a-20240925"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -28518,7 +28518,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-04bd67a4-20240924";
exports.version = "19.0.0-www-classic-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
14 changes: 7 additions & 7 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -26102,12 +26102,12 @@ __DEV__ &&
pendingPassiveEffectsLanes = 0,
pendingPassiveEffectsRemainingLanes = 0,
pendingPassiveTransitions = null,
NESTED_UPDATE_LIMIT = 50,
NESTED_UPDATE_LIMIT = 100,
nestedUpdateCount = 0,
rootWithNestedUpdates = null,
isFlushingPassiveEffects = !1,
didScheduleUpdateDuringPassiveEffects = !1,
NESTED_PASSIVE_UPDATE_LIMIT = 50,
NESTED_PASSIVE_UPDATE_LIMIT = 100,
nestedPassiveUpdateCount = 0,
rootWithPassiveNestedUpdates = null,
isRunningInsertionEffect = !1,
Expand Down Expand Up @@ -26930,11 +26930,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-www-modern-04bd67a4-20240924" !== isomorphicReactPackageVersion)
if ("19.0.0-www-modern-f9ebd85a-20240925" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-www-modern-04bd67a4-20240924\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-www-modern-f9ebd85a-20240925\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -26977,11 +26977,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-modern-04bd67a4-20240924",
version: "19.0.0-www-modern-f9ebd85a-20240925",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-modern-f9ebd85a-20240925"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -27586,7 +27586,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-04bd67a4-20240924";
exports.version = "19.0.0-www-modern-f9ebd85a-20240925";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
12 changes: 6 additions & 6 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -12247,7 +12247,7 @@ function resolveRetryWakeable(boundaryFiber, wakeable) {
retryTimedOutBoundary(boundaryFiber, retryLane);
}
function throwIfInfiniteUpdateLoopDetected() {
if (50 < nestedUpdateCount)
if (100 < nestedUpdateCount)
throw (
((nestedUpdateCount = 0),
(rootWithNestedUpdates = null),
Expand Down Expand Up @@ -17449,14 +17449,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1769 = React.version;
if (
"19.0.0-www-classic-04bd67a4-20240924" !==
"19.0.0-www-classic-f9ebd85a-20240925" !==
isomorphicReactPackageVersion$jscomp$inline_1769
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1769,
"19.0.0-www-classic-04bd67a4-20240924"
"19.0.0-www-classic-f9ebd85a-20240925"
)
);
function flushSyncFromReconciler(fn) {
Expand Down Expand Up @@ -17501,11 +17501,11 @@ Internals.Events = [
];
var internals$jscomp$inline_2277 = {
bundleType: 0,
version: "19.0.0-www-classic-04bd67a4-20240924",
version: "19.0.0-www-classic-f9ebd85a-20240925",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-classic-f9ebd85a-20240925"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2278 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17961,4 +17961,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-04bd67a4-20240924";
exports.version = "19.0.0-www-classic-f9ebd85a-20240925";
12 changes: 6 additions & 6 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -11760,7 +11760,7 @@ function resolveRetryWakeable(boundaryFiber, wakeable) {
retryTimedOutBoundary(boundaryFiber, retryLane);
}
function throwIfInfiniteUpdateLoopDetected() {
if (50 < nestedUpdateCount)
if (100 < nestedUpdateCount)
throw (
((nestedUpdateCount = 0),
(rootWithNestedUpdates = null),
Expand Down Expand Up @@ -16820,14 +16820,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1740 = React.version;
if (
"19.0.0-www-modern-04bd67a4-20240924" !==
"19.0.0-www-modern-f9ebd85a-20240925" !==
isomorphicReactPackageVersion$jscomp$inline_1740
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1740,
"19.0.0-www-modern-04bd67a4-20240924"
"19.0.0-www-modern-f9ebd85a-20240925"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -16845,11 +16845,11 @@ Internals.Events = [
];
var internals$jscomp$inline_2268 = {
bundleType: 0,
version: "19.0.0-www-modern-04bd67a4-20240924",
version: "19.0.0-www-modern-f9ebd85a-20240925",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-04bd67a4-20240924"
reconcilerVersion: "19.0.0-www-modern-f9ebd85a-20240925"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2269 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17212,4 +17212,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-04bd67a4-20240924";
exports.version = "19.0.0-www-modern-f9ebd85a-20240925";
Loading

0 comments on commit f148637

Please sign in to comment.