Skip to content

Commit

Permalink
[ci] Add yarn_test_build job to gh actions
Browse files Browse the repository at this point in the history
ghstack-source-id: 9cd55d391a57a0254dc07c0982047005a89a2390
Pull Request resolved: #30072
  • Loading branch information
poteto committed Jun 24, 2024
1 parent c46e49e commit fa313a1
Show file tree
Hide file tree
Showing 2 changed files with 62 additions and 5 deletions.
63 changes: 61 additions & 2 deletions .github/workflows/runtime_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Archive build
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.bundle_type }}-${{ matrix.release_channel }}
name: ${{ matrix.bundle_type }}_${{ matrix.release_channel }}
path: |
build/**
Expand Down Expand Up @@ -82,6 +82,65 @@ jobs:
- name: Restore archived build
uses: actions/download-artifact@v4
with:
name: ${{ matrix.bundle_type }}-${{ matrix.release_channel }}
name: ${{ matrix.bundle_type }}_${{ matrix.release_channel }}
- run: yarn install --frozen-lockfile
- run: yarn lint-build

test_build:
name: yarn test-build
needs: [define_build_params, build]
strategy:
matrix:
bundle_type: ${{ fromJSON(needs.define_build_params.outputs.bundle_type) }}
release_channel: ${{ fromJSON(needs.define_build_params.outputs.release_channel) }}
test_params: [
# Intentionally passing these as strings instead of creating a
# separate parameter per CLI argument, since it's easier to
# control/see which combinations we want to run.
-r=stable --env=development,
-r=stable --env=production,
-r=experimental --env=development,
-r=experimental --env=production,

# Dev Tools
--project=devtools -r=experimental,

# TODO: Update test config to support www build tests
# - "-r=www-classic --env=development --variant=false"
# - "-r=www-classic --env=production --variant=false"
# - "-r=www-classic --env=development --variant=true"
# - "-r=www-classic --env=production --variant=true"
# - "-r=www-modern --env=development --variant=false"
# - "-r=www-modern --env=production --variant=false"
# - "-r=www-modern --env=development --variant=true"
# - "-r=www-modern --env=production --variant=true"

# TODO: Update test config to support xplat build tests
# - "-r=xplat --env=development --variant=false"
# - "-r=xplat --env=development --variant=true"
# - "-r=xplat --env=production --variant=false"
# - "-r=xplat --env=production --variant=true"

# TODO: Test more persistent configurations?
]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
id: node_modules
with:
path: "**/node_modules"
key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
- name: Restore archived build
uses: actions/download-artifact@v4
with:
name: ${{ matrix.bundle_type }}_${{ matrix.release_channel }}
- run: yarn install --frozen-lockfile
- run: yarn test --build ${{ matrix.test_params }} --ci=github

4 changes: 1 addition & 3 deletions scripts/rollup/build-ghaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -846,9 +846,7 @@ async function buildEverything(bundleTypeToBuild) {
);

await Promise.all(
bundles.map(([bundle, bundleType]) => {
return createBundle(bundle, bundleType);
})
bundles.map(([bundle, bundleType]) => createBundle(bundle, bundleType))
);

await Packaging.copyAllShims();
Expand Down

0 comments on commit fa313a1

Please sign in to comment.