Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add DevTools jobs to gh actions #30347

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 16, 2024

Stack from ghstack (oldest at bottom):

Adds the devtools build and test jobs to GH actions. This is more or
less a straight copy of the jobs from circleci

[ghstack-poisoned]
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 4:13pm

poteto added a commit that referenced this pull request Jul 16, 2024
ghstack-source-id: 67a33545f5c6ad5952054a2d31983fe61db4fdf8
Pull Request resolved: #30347
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 16, 2024
@react-sizebot
Copy link

react-sizebot commented Jul 16, 2024

Comparing: 0117239...399a4dd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.80 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 399a4dd

[ghstack-poisoned]
@poteto poteto changed the title [ci] Add DevToolss jobs to gh actions [ci] Add DevTools jobs to gh actions Jul 16, 2024
[ghstack-poisoned]
[ghstack-poisoned]
Copy link
Contributor

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

If I understand correctly, we should also be able to migrate daily jobs for backwards-compatibility tests for RDT? There was an attempt in #28875

@poteto
Copy link
Member Author

poteto commented Jul 16, 2024

@hoxyq yeah I'll tackle those soon, everything is going to get converted to GH actions

[ghstack-poisoned]
@hoxyq
Copy link
Contributor

hoxyq commented Jul 16, 2024

I see now that react-devtools.tgz.zip is published, which contains the whole folder inside. Previously it would only publish extensions artifacts. Thanks for fixing this!

[ghstack-poisoned]
@poteto poteto merged commit 399a4dd into gh/poteto/32/base Jul 16, 2024
190 checks passed
poteto added a commit that referenced this pull request Jul 16, 2024
Adds the devtools build and test jobs to GH actions. This is more or
less a straight copy of the jobs from circleci

ghstack-source-id: f1071d754e340d440990760671a3932db74d0671
Pull Request resolved: #30347
@poteto poteto deleted the gh/poteto/32/head branch July 16, 2024 16:32
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
Adds the devtools build and test jobs to GH actions. This is more or
less a straight copy of the jobs from circleci

ghstack-source-id: f1071d754e340d440990760671a3932db74d0671
Pull Request resolved: facebook#30347
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
Adds the devtools build and test jobs to GH actions. This is more or
less a straight copy of the jobs from circleci

ghstack-source-id: f1071d754e340d440990760671a3932db74d0671
Pull Request resolved: facebook#30347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants