Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Remove DevTools jobs from circleci build_and_test #30352

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 16, 2024

Stack from ghstack (oldest at bottom):

Now that these run in GH, we can remove these jobs from the circleci
build_and_test workflow to speed up the remaining jobs left in circleci
since this was the long pole.

I have left the definition of these jobs in tact however, as they are
used for devtools_regression_tests which has yet to be migrated to GH.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 4:40pm

poteto added a commit that referenced this pull request Jul 16, 2024
Now that these run in GH, we can remove these jobs from the circleci
build_and_test workflow to speed up the remaining jobs left in circleci
since this was the long pole.

I have left the definition of these jobs in tact however, as they are
used for devtools_regression_tests which has yet to be migrated to GH.

ghstack-source-id: 6f4ed3efa2c39f2da30d664f8bb048e9f007606f
Pull Request resolved: #30352
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 16, 2024
@poteto poteto requested a review from hoxyq July 16, 2024 16:40
@react-sizebot
Copy link

Comparing: 080e36c...8e9ec34

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 8e9ec34

@poteto poteto merged commit 8e9ec34 into gh/poteto/34/base Jul 16, 2024
195 checks passed
poteto added a commit that referenced this pull request Jul 16, 2024
Now that these run in GH, we can remove these jobs from the circleci
build_and_test workflow to speed up the remaining jobs left in circleci
since this was the long pole.

I have left the definition of these jobs in tact however, as they are
used for devtools_regression_tests which has yet to be migrated to GH.

ghstack-source-id: 6f4ed3efa2c39f2da30d664f8bb048e9f007606f
Pull Request resolved: #30352
@poteto poteto deleted the gh/poteto/34/head branch July 16, 2024 19:48
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
Now that these run in GH, we can remove these jobs from the circleci
build_and_test workflow to speed up the remaining jobs left in circleci
since this was the long pole.

I have left the definition of these jobs in tact however, as they are
used for devtools_regression_tests which has yet to be migrated to GH.

ghstack-source-id: 6f4ed3efa2c39f2da30d664f8bb048e9f007606f
Pull Request resolved: facebook#30352
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
Now that these run in GH, we can remove these jobs from the circleci
build_and_test workflow to speed up the remaining jobs left in circleci
since this was the long pole.

I have left the definition of these jobs in tact however, as they are
used for devtools_regression_tests which has yet to be migrated to GH.

ghstack-source-id: 6f4ed3efa2c39f2da30d664f8bb048e9f007606f
Pull Request resolved: facebook#30352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants