Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolving of references to deduped props in lazy elements #30441

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Fix resolving of references to deduped props in lazy elements #30441

merged 4 commits into from
Jul 24, 2024

Commits on Jul 24, 2024

  1. Add a failing test for resolving blocked references of lazy elements 

    The bug was uncovered after updating React in Next.js in
vercel/next.js#66711.

The test fails with:

```
TypeError: Cannot read properties of undefined (reading 'children')
  1003 |       let value = chunk.value;
  1004 |       for (let i = 1; i < path.length; i++) {
> 1005 |         value = value[path[i]];
       |                          ^
  1006 |       }
  1007 |       const chunkValue = map(response, value);
  1008 |       if (__DEV__ && chunk._debugInfo) {

  at getOutlinedModel (packages/react-client/src/ReactFlightClient.js:1005:26)
```
    @unstubbable
    unstubbable committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3722dc7 View commit details
    Browse the repository at this point in the history

  2. Fix resolving of references to deduped props in lazy elements

    @unstubbable
    unstubbable committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d994fd2 View commit details
    Browse the repository at this point in the history

  3. Don't call waitForReference for initialized chunks

    @unstubbable
    unstubbable committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3f62042 View commit details
    Browse the repository at this point in the history

  4. Allow SomeChunk in waitForReference

    @unstubbable
    unstubbable committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f0aee7c View commit details
    Browse the repository at this point in the history