Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Cleanup --ci flag #30508

Merged
merged 10 commits into from
Jul 29, 2024
Merged

[ci] Cleanup --ci flag #30508

merged 10 commits into from
Jul 29, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 29, 2024

[ghstack-poisoned]
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:55pm

@react-sizebot
Copy link

react-sizebot commented Jul 29, 2024

Comparing: 6b82f3c...e8c6f9a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.46 kB 501.46 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 508.59 kB 508.59 kB = 91.15 kB 91.15 kB
facebook-www/ReactDOM-prod.classic.js = 596.53 kB 596.53 kB = 105.80 kB 105.80 kB
facebook-www/ReactDOM-prod.modern.js = 572.82 kB 572.82 kB = 102.01 kB 102.01 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-profiling.fb.js = 391.88 kB 390.86 kB = 68.44 kB 68.23 kB
react-native/implementations/ReactFabric-prod.fb.js = 364.38 kB 363.34 kB = 64.14 kB 63.98 kB

Generated by 🚫 dangerJS against e71c224

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@poteto poteto merged commit e71c224 into gh/poteto/3/base Jul 29, 2024
188 checks passed
poteto added a commit that referenced this pull request Jul 29, 2024
This can be restored back to being a boolean instead of an enum

ghstack-source-id: aca58fb7ea386ee489dd895e028f1aa2fc507193
Pull Request resolved: #30508
@poteto poteto deleted the gh/poteto/3/head branch July 29, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants