Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfc] Delete devtools_check_repro workflow #30518

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 29, 2024

Stack from ghstack (oldest at bottom):

With GitHub issue templates this workflow is not truly necessary and
can deny other workflows from running due to a limited amount of CI
workers in the pool.

I propose deleting this workflow and relying on issue templates instead.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 2:48pm

poteto added a commit that referenced this pull request Jul 29, 2024
With GitHub issue templates this workflow is not truly necessary and
can deny other workflows from running due to a limited amount of CI
workers in the pool.

I propose deleting this workflow and relying on issue templates instead.

ghstack-source-id: 58461aba675aea9b22489376d0db53a2ed541fb6
Pull Request resolved: #30518
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 29, 2024
@poteto poteto requested a review from hoxyq July 29, 2024 22:20
@react-sizebot
Copy link

react-sizebot commented Jul 29, 2024

Comparing: 33e54fa...1b09887

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.29 kB 501.29 kB = 89.95 kB 89.95 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 508.41 kB 508.41 kB = 91.12 kB 91.12 kB
facebook-www/ReactDOM-prod.classic.js = 596.31 kB 596.31 kB = 105.76 kB 105.76 kB
facebook-www/ReactDOM-prod.modern.js = 572.61 kB 572.61 kB = 101.96 kB 101.96 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ebbe22b

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 30, 2024
With GitHub issue templates this workflow is not truly necessary and
can deny other workflows from running due to a limited amount of CI
workers in the pool.

I propose deleting this workflow and relying on issue templates instead.

ghstack-source-id: a798621f3625fa8fffaade5a987e4024553aefa0
Pull Request resolved: #30518
@poteto poteto merged commit ebbe22b into gh/poteto/9/base Jul 30, 2024
190 checks passed
poteto added a commit that referenced this pull request Jul 30, 2024
With GitHub issue templates this workflow is not truly necessary and
can deny other workflows from running due to a limited amount of CI
workers in the pool.

I propose deleting this workflow and relying on issue templates instead.

ghstack-source-id: a798621f3625fa8fffaade5a987e4024553aefa0
Pull Request resolved: #30518
@poteto poteto deleted the gh/poteto/9/head branch July 30, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants