Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Warn for keyless fragments in an array #30588

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Conceptually this is the same as rendering this as if it was a built-in Server Component.

@sebmarkbage sebmarkbage requested a review from gnoff August 2, 2024 21:51
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 11:33pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 2, 2024
@react-sizebot
Copy link

react-sizebot commented Aug 2, 2024

Comparing: 8a70d31...412f63c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.40 kB 595.40 kB = 105.60 kB 105.60 kB
facebook-www/ReactDOM-prod.modern.js = 571.70 kB 571.70 kB = 101.80 kB 101.80 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server-flight.development.js +0.40% 99.95 kB 100.35 kB +0.41% 18.36 kB 18.43 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.29% 146.47 kB 146.89 kB +0.27% 26.91 kB 26.98 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.29% 146.62 kB 147.04 kB +0.27% 26.97 kB 27.05 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.26% 143.67 kB 144.05 kB +0.31% 26.51 kB 26.59 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.26% 144.30 kB 144.67 kB +0.30% 26.68 kB 26.76 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.25% 140.70 kB 141.04 kB +0.24% 25.99 kB 26.05 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.24% 147.07 kB 147.41 kB +0.22% 26.96 kB 27.02 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.24% 147.23 kB 147.58 kB +0.22% 27.03 kB 27.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.23% 148.18 kB 148.53 kB +0.21% 27.24 kB 27.29 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.23% 148.33 kB 148.68 kB +0.22% 27.30 kB 27.36 kB

Generated by 🚫 dangerJS against 00e41aa

env: (0, request.environmentName)(),
owner: task.debugOwner,
}: ReactComponentInfo);
if (enableOwnerStacks) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or were you supposed to remove the flag gate above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yea

@sebmarkbage sebmarkbage merged commit ba6a9e9 into facebook:main Aug 3, 2024
185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants