[compiler] Publish to latest tag #30666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Aug 12, 2024
> [!NOTE] > The `latest` tag is published by default if no tag is specified, which > is what we had done since the first release of the compiler In my last PR to auto publish compiler releases I had added the experimental tag to be used in publishing. However because we had already previously published to the latest tag (which is non-removable) this means that the `latest` tag is pinned to an old version. That makes untagged installs of the compiler default to that old version instead of whatever is the latest. This changes the behavior back to what it was before. Since we are still in the experimental release of the compiler anyway it seems fine to use the latest tag. When we reach stable, we can update this to only push to latest for stable releases. ghstack-source-id: 1809481b452150d6a452d4a77ea5482069bc7c83 Pull Request resolved: #30666
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
approved these changes
Aug 12, 2024
poteto
added a commit
that referenced
this pull request
Aug 12, 2024
> [!NOTE] > The `latest` tag is published by default if no tag is specified, which > is what we had done since the first release of the compiler In my last PR to auto publish compiler releases I had added the experimental tag to be used in publishing. However because we had already previously published to the latest tag (which is non-removable) this means that the `latest` tag is pinned to an old version. That makes untagged installs of the compiler default to that old version instead of whatever is the latest. This changes the behavior back to what it was before. Since we are still in the experimental release of the compiler anyway it seems fine to use the latest tag. When we reach stable, we can update this to only push to latest for stable releases. ghstack-source-id: 1809481b452150d6a452d4a77ea5482069bc7c83 Pull Request resolved: #30666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Note
The
latesttag is published by default if no tag is specified, whichis what we had done since the first release of the compiler
In my last PR to auto publish compiler releases I had added the
experimental tag to be used in publishing. However because we had
already previously published to the latest tag (which is non-removable)
this means that the
latesttag is pinned to an old version. That makesuntagged installs of the compiler default to that old version instead of
whatever is the latest.
This changes the behavior back to what it was before. Since we are still
in the experimental release of the compiler anyway it seems fine to use
the latest tag. When we reach stable, we can update this to only push to
latest for stable releases.