Add: reload to profile for Fusebox #31021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
EdmondChuiHW
commented
Sep 22, 2024
Comment on lines
292
to
295
| if (this._isProfiling === isProfiling) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
There are existing crashes reported on web:
Adding support for Fusebox in the PR encountered similar crashes.
These lines fix it for Fusebox; it could be the fix for web as well.
That's because onProfilingStatus is called repeatedly on some occasions, e.g. multiple calls to getProfilingStatus
EdmondChuiHW
added a commit
that referenced
this pull request
Sep 23, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Profiling fails sometimes because `onProfilingStatus` is called repeatedly on some occasions, e.g. multiple calls to `getProfilingStatus`. Subsequent calls should be a no-op if the profiling status hasn't changed. Reported via #30661 #28838. > [!TIP] > Hide whitespace changes on this PR <img width="328" alt="screenshot showing the UI controls for hiding whitespace changes on GitHub" src="https://github.com/user-attachments/assets/036385cf-2610-4e69-a717-17c05d7ef047"> ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> Tested as part of Fusebox implementation of reload-to-profile. #31021
EdmondChuiHW
force-pushed
the
reload2profile-fusebox
branch
from
daba3d8
to
4d2b22a
Compare
EdmondChuiHW
force-pushed
the
reload2profile-fusebox
branch
from
4d2b22a
to
4e24fb6
Compare
EdmondChuiHW
force-pushed
the
reload2profile-fusebox
branch
2 times, most recently
from
6be1977
to
d8da2b9
Compare
EdmondChuiHW
force-pushed
the
reload2profile-fusebox
branch
from
d8da2b9
to
78a15f4
Compare
EdmondChuiHW
added a commit
that referenced
this pull request
Sep 26, 2024
#31048) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary In preparation to support reload-to-profile in Fusebox (#31021), we need a way to check capability of different backends, e.g. web vs React Native. ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> * Default, e.g. existing web impl = no-op * Custom impl: is called
EdmondChuiHW
force-pushed
the
reload2profile-fusebox
branch
from
78a15f4
to
0dfe075
Compare
hoxyq
reviewed
Sep 26, 2024
| @@ -60,6 +63,7 @@ export function initialize( | |||
| maybeSettingsOrSettingsPromise?: | |||
| | DevToolsHookSettings | |||
| | Promise<DevToolsHookSettings>, | |||
| reloadAndProfileConfig: ReloadAndProfileConfig, | |||
There was a problem hiding this comment.
This is passed in from setUpReactDevTools.js https://www.internalfb.com/diff/D63233256?permalink=3800761013473689
There was a problem hiding this comment.
Yeah, but this is unused in this function.
You are passing this in connectToDevTools and in connectWithCustomMessagingProtocol, and you are using it there
There was a problem hiding this comment.
We're using it in all three places. initialize needs the initial (heh) boolean values to pass onto renderer, and the connect* functions need the full *ConfigPersistence to read & write the flags
Edit: LOL I see what you mean now 🤦♂️ Thanks for the permalink.
react/packages/react-devtools-core/src/backend.js
Lines 62 to 69 in ba97e6e
It got messed up during rebase. Fixed now
EdmondChuiHW
force-pushed
the
reload2profile-fusebox
branch
from
0dfe075
to
ba97e6e
Compare
hoxyq
approved these changes
Sep 26, 2024
EdmondChuiHW
force-pushed
the
reload2profile-fusebox
branch
from
ba97e6e
to
feace7e
Compare
gnoff
added a commit
to vercel/next.js
that referenced
this pull request
Sep 27, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`** [diff facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000) <details> <summary>React upstream changes</summary> - facebook/react#31078 - facebook/react#31083 - facebook/react#31079 - facebook/react#31080 - facebook/react#31076 - facebook/react#31021 - facebook/react#31069 - facebook/react#31074 - facebook/react#31073 - facebook/react#31047 - facebook/react#31046 - facebook/react#31045 - facebook/react#31072 - facebook/react#30980 - facebook/react#30463 - facebook/react#30694 - facebook/react#31039 - facebook/react#31048 - facebook/react#31068 </details> --------- Co-authored-by: Josh Story <[email protected]>
abhi12299
pushed a commit
to abhi12299/next.js
that referenced
this pull request
Sep 29, 2024
…#70560) **breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`** [diff facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000) <details> <summary>React upstream changes</summary> - facebook/react#31078 - facebook/react#31083 - facebook/react#31079 - facebook/react#31080 - facebook/react#31076 - facebook/react#31021 - facebook/react#31069 - facebook/react#31074 - facebook/react#31073 - facebook/react#31047 - facebook/react#31046 - facebook/react#31045 - facebook/react#31072 - facebook/react#30980 - facebook/react#30463 - facebook/react#30694 - facebook/react#31039 - facebook/react#31048 - facebook/react#31068 </details> --------- Co-authored-by: Josh Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add reload to profile for Fusebox
Stacked on #31048. See 6be1977
How did you test this change?
Test E2E in D63233256