Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable enablePostpone flag in experimental #31042

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Sep 24, 2024

I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage.

The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and use() because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's use() and not just throwing a Promise. This might also affect the Catch proposal.

The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the React.postpone() API for creating the holes.

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 6:28am

@react-sizebot
Copy link

Comparing: 4708fb9...6fa45b8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.10 kB 509.10 kB = 91.06 kB 91.06 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.04 kB 513.03 kB = 91.78 kB 91.64 kB
facebook-www/ReactDOM-prod.classic.js = 603.53 kB 603.53 kB = 106.78 kB 106.78 kB
facebook-www/ReactDOM-prod.modern.js = 579.76 kB 579.76 kB = 102.88 kB 102.88 kB
oss-experimental/react-markup/cjs/react-markup.development.js = 346.55 kB 339.49 kB = 62.67 kB 62.05 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js = 251.58 kB 246.25 kB = 44.82 kB 44.23 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js = 245.95 kB 240.72 kB = 42.84 kB 42.27 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js = 247.42 kB 242.09 kB = 43.90 kB 43.31 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js = 224.59 kB 219.26 kB = 40.70 kB 40.09 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js = 223.63 kB 218.28 kB = 41.23 kB 40.63 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js = 218.66 kB 213.43 kB = 39.38 kB 38.80 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 510.36 kB 497.36 kB = 90.96 kB 89.65 kB
oss-experimental/react-markup/cjs/react-markup.production.js = 206.78 kB 201.47 kB = 38.51 kB 37.93 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 102.81 kB 99.86 kB = 20.71 kB 20.28 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 102.78 kB 99.83 kB = 20.72 kB 20.29 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 101.82 kB 98.87 kB = 20.44 kB 20.08 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js = 307.65 kB 298.71 kB = 57.46 kB 56.49 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 99.66 kB 96.68 kB = 20.02 kB 19.60 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 99.35 kB 96.37 kB = 19.88 kB 19.50 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 99.79 kB 96.73 kB = 20.04 kB 19.61 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 99.76 kB 96.70 kB = 20.04 kB 19.62 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.84 kB 92.89 kB = 19.49 kB 19.13 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 156.41 kB 151.20 kB = 28.50 kB 27.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 156.37 kB 151.16 kB = 28.50 kB 27.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 152.28 kB 147.20 kB = 27.69 kB 27.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 151.84 kB 146.76 kB = 27.58 kB 26.97 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 155.27 kB 150.06 kB = 28.18 kB 27.57 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 148.57 kB 143.37 kB = 27.14 kB 26.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 154.69 kB 149.25 kB = 27.99 kB 27.33 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 154.65 kB 149.22 kB = 27.99 kB 27.33 kB
oss-experimental/react-server/cjs/react-server.development.js = 177.42 kB 170.36 kB = 31.34 kB 30.70 kB
oss-experimental/react-server/cjs/react-server-flight.development.js = 106.35 kB 101.27 kB = 19.14 kB 18.55 kB
oss-experimental/react-server/cjs/react-server.production.js = 122.44 kB 116.40 kB = 21.56 kB 20.93 kB
oss-experimental/react-server/cjs/react-server-flight.production.js = 64.64 kB 61.35 kB = 12.55 kB 12.15 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-art/cjs/react-art.development.js = 571.21 kB 570.07 kB = 92.39 kB 92.19 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 423.50 kB 422.41 kB = 69.07 kB 68.92 kB
oss-experimental/react-art/cjs/react-art.production.js = 304.21 kB 303.40 kB = 52.28 kB 52.10 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 390.33 kB 389.24 kB = 63.98 kB 63.82 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 100.70 kB 100.08 kB = 19.06 kB 18.96 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 99.91 kB 99.28 kB = 18.88 kB 18.78 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 98.18 kB 97.53 kB = 18.76 kB 18.65 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 98.16 kB 97.51 kB = 18.78 kB 18.67 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 96.80 kB 96.14 kB = 18.52 kB 18.42 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 92.26 kB 91.63 kB = 17.00 kB 16.86 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 94.57 kB 93.92 kB = 18.06 kB 17.94 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 92.69 kB 92.04 kB = 17.58 kB 17.46 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 92.24 kB 91.59 kB = 17.47 kB 17.35 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 90.38 kB 89.73 kB = 17.07 kB 16.96 kB
oss-experimental/react-client/cjs/react-client-flight.production.js = 54.68 kB 54.27 kB = 10.28 kB 10.22 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 128.04 kB 127.08 kB = 30.15 kB 29.99 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 57.35 kB 56.86 kB = 11.62 kB 11.55 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 56.66 kB 56.17 kB = 11.46 kB 11.39 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 54.94 kB 54.43 kB = 11.32 kB 11.25 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 54.92 kB 54.42 kB = 11.33 kB 11.26 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 78.33 kB 77.59 kB = 16.61 kB 16.50 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 53.78 kB 53.27 kB = 11.10 kB 11.03 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 51.82 kB 51.32 kB = 10.66 kB 10.60 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 49.51 kB 49.00 kB = 10.12 kB 10.05 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 49.18 kB 48.67 kB = 10.03 kB 9.96 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 47.57 kB 47.06 kB = 9.66 kB 9.59 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 400.58 kB 393.50 kB = 69.88 kB 69.23 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 399.83 kB 392.76 kB = 69.77 kB 69.11 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 395.52 kB 388.45 kB = 69.13 kB 68.48 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 334.96 kB 328.66 kB = 63.88 kB 63.24 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 375.15 kB 368.06 kB = 66.93 kB 66.29 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 375.14 kB 368.06 kB = 66.93 kB 66.29 kB
oss-experimental/react-markup/cjs/react-markup.development.js = 346.55 kB 339.49 kB = 62.67 kB 62.05 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js = 251.58 kB 246.25 kB = 44.82 kB 44.23 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js = 245.95 kB 240.72 kB = 42.84 kB 42.27 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js = 247.42 kB 242.09 kB = 43.90 kB 43.31 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js = 224.59 kB 219.26 kB = 40.70 kB 40.09 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js = 223.63 kB 218.28 kB = 41.23 kB 40.63 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js = 218.66 kB 213.43 kB = 39.38 kB 38.80 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 510.36 kB 497.36 kB = 90.96 kB 89.65 kB
oss-experimental/react-markup/cjs/react-markup.production.js = 206.78 kB 201.47 kB = 38.51 kB 37.93 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 102.81 kB 99.86 kB = 20.71 kB 20.28 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 102.78 kB 99.83 kB = 20.72 kB 20.29 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 101.82 kB 98.87 kB = 20.44 kB 20.08 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js = 307.65 kB 298.71 kB = 57.46 kB 56.49 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 99.66 kB 96.68 kB = 20.02 kB 19.60 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 99.35 kB 96.37 kB = 19.88 kB 19.50 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 99.79 kB 96.73 kB = 20.04 kB 19.61 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 99.76 kB 96.70 kB = 20.04 kB 19.62 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.84 kB 92.89 kB = 19.49 kB 19.13 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 156.41 kB 151.20 kB = 28.50 kB 27.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 156.37 kB 151.16 kB = 28.50 kB 27.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 152.28 kB 147.20 kB = 27.69 kB 27.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 151.84 kB 146.76 kB = 27.58 kB 26.97 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 155.27 kB 150.06 kB = 28.18 kB 27.57 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 148.57 kB 143.37 kB = 27.14 kB 26.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 154.69 kB 149.25 kB = 27.99 kB 27.33 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 154.65 kB 149.22 kB = 27.99 kB 27.33 kB
oss-experimental/react-server/cjs/react-server.development.js = 177.42 kB 170.36 kB = 31.34 kB 30.70 kB
oss-experimental/react-server/cjs/react-server-flight.development.js = 106.35 kB 101.27 kB = 19.14 kB 18.55 kB
oss-experimental/react-server/cjs/react-server.production.js = 122.44 kB 116.40 kB = 21.56 kB 20.93 kB
oss-experimental/react-server/cjs/react-server-flight.production.js = 64.64 kB 61.35 kB = 12.55 kB 12.15 kB

Generated by 🚫 dangerJS against 497c6e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants