Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make prerendering always non-blocking #31056

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Make prerendering always non-blocking #31056

merged 2 commits into from
Sep 25, 2024
+298 −137

Commits on Sep 25, 2024

  1. Add missing feature flag checks 

    Neglected to wrap some places in the enableSiblingPrerendering flag.
    @acdlite
    acdlite committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2a9fb44 View commit details
    Browse the repository at this point in the history

  2. Make prerendering always non-blocking 

    When a synchronous update suspends, and we prerender the siblings, the
prerendering should be non-blocking so that we can immediately restart
once the data arrives.

This happens automatically when there's a Suspense boundary, because
we immediately commit the boundary and then proceed to a Retry render,
which are always concurrent. When there's not a Suspense boundary, there
is no Retry, so we need to take care to switch from the synchronous
work loop to the concurrent one, to enable time slicing.
    @acdlite
    acdlite committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4c71025 View commit details
    Browse the repository at this point in the history