Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependabot] Ignore all fixture directories #31074

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Sep 26, 2024

Stack from ghstack (oldest at bottom):

Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

[ghstack-poisoned]
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:25pm

poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: a47db58ad97c5dd7adc27ced25d39806c728410b
Pull Request resolved: #31074
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 26, 2024
@react-sizebot
Copy link

react-sizebot commented Sep 26, 2024

Comparing: b7f74f3...f27aa92

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 507.20 kB 507.20 kB = 90.80 kB 90.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.13 kB 512.13 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 603.73 kB 603.73 kB = 106.84 kB 106.83 kB
facebook-www/ReactDOM-prod.modern.js = 579.95 kB 579.95 kB = 102.92 kB 102.92 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 65f9009

Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify this a bunch using directories, per https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#directories

it should support wildcards for the plural version.

So something like

  - package-ecosystem: "npm"
    directories:
      - "/fixtures/*"
    schedule:
      interval: "monthly"
    ignore:
      - dependency-name: "*"

@poteto
Copy link
Member Author

poteto commented Sep 26, 2024

@kassens oh sweet, nice find!

[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: bae3a9ef9d4b13eb9d46f5a6a18a99566789f466
Pull Request resolved: #31074
@poteto poteto requested a review from kassens September 26, 2024 14:19
.github/dependabot.yml Outdated Show resolved Hide resolved
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: 8864a902789de855354579ee9e2300585ab5edf1
Pull Request resolved: #31074
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: 64b76bd532663cdc4db10ba6299e791b5908d5b1
Pull Request resolved: #31074
@poteto poteto merged commit 65f9009 into gh/poteto/16/base Sep 26, 2024
185 checks passed
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: 64b76bd532663cdc4db10ba6299e791b5908d5b1
Pull Request resolved: #31074
@poteto poteto deleted the gh/poteto/16/head branch September 26, 2024 14:34
gnoff added a commit to vercel/next.js that referenced this pull request Sep 27, 2024
abhi12299 pushed a commit to abhi12299/next.js that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants