[compiler][fixtures] Patch error-handling edge case in snap evaluator #31082
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
| @@ -75,7 +75,7 @@ export const FIXTURE_ENTRYPOINT = { | |||
|
|
|||
| ### Eval output | |||
| (kind: ok) [[ (exception in render) Error: throw with error! ]] | |||
| [[ (exception in render) Error: throw with error! ]] | |||
| [2] | |||
There was a problem hiding this comment.
Note that we now correctly do the non-throwing re-render instead of returning a cached error
| if (this.state.hasError) { | ||
| this.setState({hasError: false, error: null}); | ||
| if (this.state.errorFromLastRender !== NO_ERROR_SENTINEL) { | ||
| // Reschedule a third render that immediately returns the cached error |
There was a problem hiding this comment.
i don't get the comment here, seems backwards since we're clearing errorFromLastRender? wouldn't this not immediately return the error?
There was a problem hiding this comment.
This wouldn't return errorFromLastRender, but it would find the correct one in this.propsErrorMap.
I had trouble figuring out another solution to render components exactly once (per entry in sequentialRenders) and clear the error-state to retry rendering when props change
Definitely not sold that this is the best way writing this and I'm probably missing a common pattern, any suggestions welcome.
Fix edge case in which we incorrectly returned a cached exception instead of trying to rerender with new props. ghstack-source-id: 843fb85df4a2ae7a88f296104fb16b5f9a34c76e Pull Request resolved: #31082
Stack from ghstack (oldest at bottom):
Fix edge case in which we incorrectly returned a cached exception instead of trying to rerender with new props.