Define HostInstance
type for React Native
#31101
Open
+12
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creates a new
HostInstance
type for React Native, to more accurately capture the intent most developers have when using theNativeMethods
type orReact.ElementRef<HostComponent<T>>
.Since
React.ElementRef<HostComponent<T>>
is typed asReact.AbstractComponent<T, NativeMethods>
, that meansReact.ElementRef<HostComponent<T>>
is equivalent toNativeMethods
which is equivalent toHostInstance
.How did you test this change?