Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] set disableLegacyMode to true #31439

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[www] set disableLegacyMode to true #31439

merged 1 commit into from
Nov 7, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Nov 6, 2024

No description provided.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 7:29pm

@react-sizebot
Copy link

react-sizebot commented Nov 6, 2024

Comparing: e137890...0748065

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 506.41 kB 506.41 kB = 90.49 kB 90.49 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 511.34 kB 511.34 kB = 91.20 kB 91.20 kB
facebook-www/ReactDOM-prod.classic.js = 602.31 kB 588.07 kB = 106.33 kB 104.00 kB
facebook-www/ReactDOM-prod.modern.js = 578.34 kB 578.34 kB = 102.41 kB 102.41 kB
facebook-www/ReactART-prod.classic.js = 368.68 kB 361.19 kB = 62.24 kB 61.03 kB
facebook-www/ReactDOMTesting-prod.classic.js = 617.03 kB 602.79 kB = 110.04 kB 107.68 kB
facebook-www/ReactDOM-profiling.classic.js = 630.08 kB 615.24 kB = 110.28 kB 107.87 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,102.90 kB 1,076.42 kB = 185.99 kB 181.66 kB
facebook-www/ReactDOM-dev.classic.js = 1,086.00 kB 1,059.51 kB = 182.02 kB 177.74 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/React-dev.classic.js = 68.36 kB 67.58 kB = 15.05 kB 14.93 kB
facebook-www/ReactReconciler-prod.classic.js = 462.31 kB 453.62 kB = 74.73 kB 73.44 kB
facebook-www/ReactART-dev.classic.js = 654.16 kB 641.51 kB = 104.63 kB 102.88 kB
facebook-www/ReactReconciler-dev.classic.js = 740.84 kB 726.42 kB = 117.99 kB 115.67 kB
facebook-www/ReactART-prod.classic.js = 368.68 kB 361.19 kB = 62.24 kB 61.03 kB
facebook-www/ReactDOMTesting-prod.classic.js = 617.03 kB 602.79 kB = 110.04 kB 107.68 kB
facebook-www/ReactDOM-profiling.classic.js = 630.08 kB 615.24 kB = 110.28 kB 107.87 kB
facebook-www/ReactDOM-prod.classic.js = 602.31 kB 588.07 kB = 106.33 kB 104.00 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,102.90 kB 1,076.42 kB = 185.99 kB 181.66 kB
facebook-www/ReactDOM-dev.classic.js = 1,086.00 kB 1,059.51 kB = 182.02 kB 177.74 kB

Generated by 🚫 dangerJS against 7c0c424

Copy link
Contributor

@jackpope jackpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@kassens kassens merged commit 682a103 into facebook:main Nov 7, 2024
184 checks passed
@kassens kassens deleted the pr31439 branch November 7, 2024 14:05
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants