Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dist-tag canaries with rc #31546

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Nov 15, 2024

We used to tag canaries with rc whenever we were in the RC phase of a release cycle. But now that publish "real" versioned canaries like 19.0.0-rc.1, it's confusing that the rc dist-tag could point to an even newer version than that.

So this removes the rc dist-tag from the canary publish workflow.

We used to tag canaries with `rc` whenever we were in the RC phase of
a release cycle. But now that publish "real" versioned canaries like
19.0.0-rc.1, it's confusing that the `rc` dist-tag could point to an
even newer version than that.

So this removes the `rc` dist-tag from the canary publish workflow.
@acdlite acdlite requested a review from poteto November 15, 2024 00:42
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:44am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 15, 2024
Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@react-sizebot
Copy link

Comparing: 63cde68...1d30dd8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.09 kB 509.09 kB = 91.00 kB 91.00 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.03 kB 514.03 kB = 91.71 kB 91.71 kB
facebook-www/ReactDOM-prod.classic.js = 588.71 kB 588.71 kB = 104.18 kB 104.18 kB
facebook-www/ReactDOM-prod.modern.js = 578.98 kB 578.98 kB = 102.59 kB 102.59 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 71ebdd1

@eps1lon eps1lon merged commit e1ef8c9 into facebook:main Nov 15, 2024
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants