Skip to content

Commit

Permalink
Do not run continuous verification interval unless we explicitly set …
Browse files Browse the repository at this point in the history
…FLAGS_continuous_verification_interval
  • Loading branch information
archang19 committed Jan 9, 2025
1 parent 870fd18 commit 4462b6e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
10 changes: 9 additions & 1 deletion db_stress_tool/no_batched_ops_stress.cc
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,15 @@ class NonBatchedOpsStressTest : public StressTest {
}

void ContinuouslyVerifyDb(ThreadState* thread) const override {
if (!secondary_db_) {
// Currently this method gets calleds even when
// FLAGS_continuous_verification_interval == 0 as long as
// FLAGS_verify_db_one_in > 0. Previously, this was not causing a problem in
// the crash tests since test_secondary was always equal to 0, and thus we
// returned early from this method. When test_secondary is set and we have a
// secondary_db_, the crash test fails during this iterator scan. The stack
// trace mentions BlobReader/BlobSource but it may not necessarily be
// related to BlobDB
if (!secondary_db_ || !FLAGS_continuous_verification_interval) {
return;
}
assert(secondary_db_);
Expand Down
3 changes: 3 additions & 0 deletions tools/db_crashtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1023,6 +1023,9 @@ def finalize_and_sanitize(src_params):
if dest_params.get("track_and_verify_wals", 0) == 1:
dest_params["metadata_write_fault_one_in"] = 0
dest_params["write_fault_one_in"] = 0
# Continuous verification fails with secondaries inside NonBatchedOpsStressTest
if dest_params.get("test_secondary") == 1:
dest_params["continuous_verification_interval"] = 0
return dest_params


Expand Down

0 comments on commit 4462b6e

Please sign in to comment.