Eliminate some parameters redundant with ReadOptions #12761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ... in Index and CompressionDict readers (Filters in another PR). no_io and verify_checksums should be inferred from ReadOptions rather than specified redundantly. Fixes incomplete propagation of ReadOptions in UncompressionDictReader::GetOrReadUncompressionDictionar so is technically a functional change. (Related to facebook#12757) Also there was hardcoded no verify_checksums in DumpTable, but only for UncompressionDict, which doesn't make sense. Now using consistent ReadOptions and verify_checksum can be controlled for more reads together. Test Plan: existing tests
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
reviewed
Jun 12, 2024
| GetOrReadIndexBlock(/*no_io=*/true, /*get_context=*/nullptr, | ||
| /*lookup_context=*/nullptr, &top_level_block, | ||
| ReadOptions{}) | ||
| ReadOptions ro_no_io; |
There was a problem hiding this comment.
Is this intentional that we don't pass down read options here?
There was a problem hiding this comment.
We aren't in the context of a read operation (no ReadOptions passed in), but we are in a context where we are very much forbidden from reading from storage, because that would destroy the purpose of pro-actively erasing obsolete cache entries.
hx235
approved these changes
Jun 12, 2024
|
@pdillinger merged this pull request in 5cf3bed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: ... in Index and CompressionDict readers (Filters in another PR). no_io and verify_checksums should be inferred from ReadOptions rather than specified redundantly.
Fixes incomplete propagation of ReadOptions in
UncompressionDictReader::GetOrReadUncompressionDictionar so is technically a functional change. (Related to #12757)
Also there was hardcoded no verify_checksums in DumpTable, but only for UncompressionDict, which doesn't make sense. Now using consistent ReadOptions and verify_checksum can be controlled for more reads together.
Test Plan: existing tests