Skip to content

Commit

Permalink
teach eden reloadconfig to handle --manifold-key
Browse files Browse the repository at this point in the history
Summary:
# Context
To test edenfs_config changes, one can upload the raw config to manifold and ask the edenfs_config_manager to use that raw config rather than canarying the change to a machine or having a local configerator checkout.

# This Diff
I added this flag mid last year (D61072490) but didn't add it to the helper cli `reloadconfig`. This diff adds it to `reloadconfig` for ease of use. `reloadconfig` just passes the args to the `edenfs_config_manager` so you don't have to remember the path for invoking the manager.

Reviewed By: ViniGupta08

Differential Revision: D68801571

fbshipit-source-id: 8ae36a96886d6a50a108f158a254a7ecfbe381f8
  • Loading branch information
genevievehelsel authored and facebook-github-bot committed Jan 29, 2025
1 parent 38f9ac6 commit d129c4b
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions eden/fs/cli_rs/edenfs-commands/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ pub struct ReloadConfigCmd {
)]
canary_host: Option<PathBuf>,

#[clap(
long,
help = "Load configs from the edenfs_test_configs Manifold bucket instead of reading from remote. This is useful for testing changes locally without having to push them to production"
)]
manifold_key: Option<String>,

#[clap(
long,
help = "If the script is ran as root, used to specify user when making requests to Configerator. Defaults to SUDO_USER, $LOGUSER, os.getlogin, or \"unknown\" in that order."
Expand Down Expand Up @@ -165,6 +171,10 @@ impl crate::Subcommand for ReloadConfigCmd {
cmd.arg("--canary-host").arg(canary_host);
}

if let Some(manifold_key) = &self.manifold_key {
cmd.arg("--manifold-key").arg(manifold_key);
}

if let Some(user) = &self.user {
cmd.arg("--user").arg(user);
}
Expand Down

0 comments on commit d129c4b

Please sign in to comment.