Skip to content

Commit

Permalink
more verbosity in 'eden prefetch-profile fetch-predictive'
Browse files Browse the repository at this point in the history
Summary:
# This diff

Makes 'eden prefetch-profile fetch-predictive' more verbose by removing some verbosity restrictions. This makes the output of the command more informative.

# Context

It's unclear to users that the `prefetch-profile fetch-predictive` command worked as expected. This is because no output is printed, and the verbose option doesn't even print out whether the prefetch was started/finished.

Adding this output should give users advice on how to check if the prefetch is doing work or not.

Reviewed By: genevievehelsel

Differential Revision: D68860828

fbshipit-source-id: 80368d6dfaaa32b21072e5aeb5fe0f37862085e7
MichaelCuevas authored and facebook-github-bot committed Jan 30, 2025
1 parent 25fac38 commit fbd36b0
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions eden/fs/cli_rs/edenfs-commands/src/prefetch_profile.rs
Original file line number Diff line number Diff line change
@@ -515,12 +515,10 @@ impl PrefetchCmd {
})?;

if if_active && !checkout_config.predictive_prefetch_is_active() {
if options.options.verbose {
println!(
"Predictive prefetch profiles have not been activated and \
--if-active was specified. Skipping fetch."
);
}
eprintln!(
"Predictive prefetch profiles have not been activated and \
--if-active was specified. Skipping fetch."
);
return Ok(0);
}

0 comments on commit fbd36b0

Please sign in to comment.