Skip to content

Commit

Permalink
Use crossAxisOwnerSize instead of ownerHeight in cross axis bound call (
Browse files Browse the repository at this point in the history
#1763)

Summary:
Pull Request resolved: #1763

X-link: facebook/react-native#48080

Small bug that I noticed while doing intrinsic sizing. We have the ownerHeight as the axis size despite bounding the length of the cross axis. This should therefore be the crossAxisOwnerSize, which might be the width in some cases

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D66736539

fbshipit-source-id: 528fc438b3327cd6f7890ea0ba408e4ce7b0f02c
  • Loading branch information
joevilches authored and facebook-github-bot committed Dec 6, 2024
1 parent 050ac8a commit 5478812
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion yoga/algorithm/CalculateLayout.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1780,7 +1780,7 @@ static void calculateLayoutImpl(
crossAxis,
direction,
unclampedCrossDim,
ownerHeight,
crossAxisOwnerSize,
ownerWidth) -
paddingAndBorderAxisCross;

Expand Down

0 comments on commit 5478812

Please sign in to comment.