Skip to content

Commit

Permalink
GitHub Actions Cleanup (#1467)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1467

1. Avoid reusing workflow names between validation and publish jobs, since they show up with the same UI when wanting to adhoc trigger a publish.
2. Merge SwiftPM checks into Validate Apple job
3. Merge remnants of website-next workflow into website workflow (and remove a redundant explicit build step already removed in one workflow)
4. Run more validation on push to release branch
5. Do not run website validation off of main, since it is only ever deployed from main branch

Reviewed By: cipolleschi

Differential Revision: D51236885

fbshipit-source-id: dd8165aa9871f173d8914f345569c6cde1edda72
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Nov 13, 2023
1 parent 6f41a27 commit 8c1a672
Show file tree
Hide file tree
Showing 9 changed files with 40 additions and 91 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish-website.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Website
name: Publish Website

on:
push:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/validate-android.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: Android
name: Validate Android

on:
pull_request:
push:
branches:
- main
- 'release-*'
workflow_dispatch:

jobs:
Expand Down
18 changes: 16 additions & 2 deletions .github/workflows/validate-apple.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
name: Apple
name: Validate Apple

on:
pull_request:
push:
branches:
- main
- 'release-*'
workflow_dispatch:

jobs:
lint-pods:
name: Lint pod
name: Build [CocoaPods]
runs-on: macos-latest

steps:
Expand All @@ -20,3 +21,16 @@ jobs:

- name: pod lib lint
run: pod lib lint --verbose --include-podspecs=**/*.podspec

test:
name: Build [SwiftPM]
runs-on: macos-latest

steps:
- uses: actions/checkout@v3

- name: Build Debug
run: swift build -c debug

- name: Build Release
run: swift build -c release
3 changes: 2 additions & 1 deletion .github/workflows/validate-cpp.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: C++
name: Validate C++

on:
pull_request:
push:
branches:
- main
- 'release-*'
workflow_dispatch:

env:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/validate-js.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: JavaScript
name: Validate JavaScript

on:
pull_request:
push:
branches:
- main
- 'release-*'
workflow_dispatch:

env:
Expand Down
21 changes: 0 additions & 21 deletions .github/workflows/validate-python.yml

This file was deleted.

22 changes: 0 additions & 22 deletions .github/workflows/validate-swiftpm.yml

This file was deleted.

37 changes: 0 additions & 37 deletions .github/workflows/validate-website-next.yml

This file was deleted.

22 changes: 17 additions & 5 deletions .github/workflows/validate-website.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: Website
name: Validate Website

on:
pull_request:
branches:
- main
push:
branches:
- main
Expand Down Expand Up @@ -32,10 +34,20 @@ jobs:
- name: Setup
uses: ./.github/actions/setup-js

- name: Build Yoga
run: yarn build
working-directory: javascript

- name: Build Website
run: yarn build
working-directory: website-next

typecheck:
name: Typecheck [Docusaurus]
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Setup
uses: ./.github/actions/setup-js

- name: yarn tsc
run: yarn tsc
working-directory: website-next

0 comments on commit 8c1a672

Please sign in to comment.