Skip to content

Commit

Permalink
GitHub workflow to ensure tests are up to date (#1505)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1505

This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :)

Reviewed By: NickGerleman

Differential Revision: D52002920

fbshipit-source-id: 24167da1bd10a18ea66239b337fcb32ac309e424
  • Loading branch information
joevilches authored and facebook-github-bot committed Dec 12, 2023
1 parent 59d66f3 commit eeafe39
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
33 changes: 33 additions & 0 deletions .github/workflows/validate-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Validate Tests

on:
pull_request:
push:
branches:
- main
- 'release-*'
workflow_dispatch:

jobs:
validate:
name: Validate
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Setup JS
uses: ./.github/actions/setup-js

- name: yarn gentest-validate
run: yarn gentest-validate

- name: yarn gentest
run: yarn gentest -h

- name: Check for modified tests
run: |
if [[ -n $(git status -s) ]]; then
git status -s
echo "yarn gentest modified these tests. Please run yarn gentest to resolve."
exit 1
fi
2 changes: 2 additions & 0 deletions gentest/gentest-driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ function addSignatureToSourceCode(sourceCode: string): string {
const argv = minimist(process.argv.slice(2));
const specificFixture = argv.f || argv.fixture;
const suspend = argv.s || argv.suspend;
const headless = argv.h || argv.headless;

const gentestDir = dirname(fileURLToPath(import.meta.url));
const yogaDir = dirname(gentestDir);
Expand All @@ -54,6 +55,7 @@ options.addArguments(
'--window-position=0,0',
'--hide-scrollbars',
);
headless && options.addArguments('--headless');
options.setLoggingPrefs({
browser: 'ALL',
performance: 'ALL',
Expand Down

0 comments on commit eeafe39

Please sign in to comment.