Backout "Add tests for absolute positioning of children with padding in the parent" #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the parent" Summary: Backing out D50670457 Github PR is: facebook@4f98bfe That PR started failing our workflows due to a build error in gtest. It seems unlikely that it is due to that change but backing it out to see if it fixes that issue. https://github.com/facebook/yoga/actions/runs/6657567207/job/18095847672 Differential Revision: D50708256
|
This pull request was exported from Phabricator. Differential Revision: D50708256 |
|
@joevilches I think this is likely due to a change in the ubuntu-latest image. The error is happening in headers for GCC stdlibc++. The clang build should instead be using LLVM libc++. I think we could try to follow the solution in https://stackoverflow.com/questions/76859275/error-compiling-a-cpp-containing-stdchrono-errorstatic-constexpr-unsigned-fra in project-defaults.cmake, conditionally when compiling with Clang. |
|
Here’s some information I found about the stdlib included by default. https://stackoverflow.com/questions/19774778/when-is-it-necessary-to-use-the-flag-stdlib-libstdc |
|
Looks tentatively like #1440 should fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Backing out D50670457
Github PR is: 4f98bfe
That PR started failing our workflows due to a build error in gtest. It seems unlikely that it is due to that change but backing it out to see if it fixes that issue.
https://github.com/facebook/yoga/actions/runs/6657567207/job/18095847672
Differential Revision: D50708256