CompactValue -> Style::Length #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 9, 2023
Summary: X-link: facebook/react-native#41392 Pull Request resolved: facebook#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: e1b0bb950f0f1fa1daa1b050f96d5e13661b32f7
NickGerleman
force-pushed
the
export-D51000389
branch
from
665f3d5 to
92cd76c
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 9, 2023
Summary: Pull Request resolved: facebook#41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 3a9667827e1a522731181c95e770fd78fd585f11
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41392 Pull Request resolved: facebook#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: fa38b44a472e4914e4fafde099993791d1ed2946
NickGerleman
force-pushed
the
export-D51000389
branch
from
92cd76c to
98239ea
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: Pull Request resolved: facebook#41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 8518eedb2522f754bf0b1966bdedc12a7769ea69
NickGerleman
force-pushed
the
export-D51000389
branch
from
98239ea to
22ed178
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 676e90f0f13a8681890a9e436eee62c8ab41eb38
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
force-pushed
the
export-D51000389
branch
from
22ed178 to
cce215d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
force-pushed
the
export-D51000389
branch
from
cce215d to
42e9470
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 1afb75ddcc06b671a09b1c60d60d2e43f0409815
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 1c6a1b5ce72cfa967cb3ffaec18c349907de0f64
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
force-pushed
the
export-D51000389
branch
from
42e9470 to
10b94f7
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
force-pushed
the
export-D51000389
branch
from
3ddeeae to
042a2d0
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
force-pushed
the
export-D51000389
branch
from
042a2d0 to
e92d09c
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
force-pushed
the
export-D51000389
branch
from
e92d09c to
425885e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
force-pushed
the
export-D51000389
branch
from
425885e to
fbbf56d
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
|
This pull request was exported from Phabricator. Differential Revision: D51000389 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41392 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/react-native#41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 00f55e72bfb8aa291b53308f8a62ac8797be490f
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 26, 2023
Summary: Pull Request resolved: #41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 00f55e72bfb8aa291b53308f8a62ac8797be490f
|
This pull request has been merged in aca0240. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41392 X-link: facebook/yoga#1458 We're moving `CompactValue` to be an internal detail of `yoga::Style`, where users outside of the style will be dealing with a resolved/non-compact representation. This change renames usages of `CompactValue` to `Style::Length`, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same. A few factory functions are added to `yoga::value` for creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reused `point` until making other changes. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D51000389 fbshipit-source-id: 00f55e72bfb8aa291b53308f8a62ac8797be490f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're moving
CompactValueto be an internal detail ofyoga::Style, where users outside of the style will be dealing with a resolved/non-compact representation.This change renames usages of
CompactValuetoStyle::Length, which will be Yoga's representation for CSS input lengths. Right now one is just a type alias of the other, but this will let us change the internals of CompactValue with the rest of the world looking the same.A few factory functions are added to
yoga::valuefor creating CSS values. There are some shenanigans around how we want to represent CSS pixels (one YGUnitPoint), when we also end up adding CSS points (slightly larger than one YGUnitPoint). For now, I reusedpointuntil making other changes.Changelog: [Internal]
Reviewed By: yungsters
Differential Revision: D51000389