Fix MacCatalyst archiving for stand-alone pod #1585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D54417386 |
cipolleschi
force-pushed
the
export-D54417386
branch
from
c7cc4ed to
a55a9d9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54417386 |
cipolleschi
added a commit
to cipolleschi/yoga
that referenced
this pull request
Mar 4, 2024
Summary: When used alone, yoga has no visibility over the USE_FRAMEWORKS variable set by React Native. In this case, there is no other way to know whether the current target that will install the spec is using use_framewors or not. As a failsafe, condition, let's always add the `"$(PODS_TARGET_SRCROOT)"` to the search paths to make sure that archiving won't fail. Whe used in other context, that should not be a problem: search paths are just directory Xcode uses to find headers that are needed. Reviewed By: NickGerleman Differential Revision: D54417386
cipolleschi
force-pushed
the
export-D54417386
branch
from
a55a9d9 to
e5c831c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54417386 |
cipolleschi
added a commit
to cipolleschi/yoga
that referenced
this pull request
Mar 4, 2024
Summary: When used alone, yoga has no visibility over the USE_FRAMEWORKS variable set by React Native. In this case, there is no other way to know whether the current target that will install the spec is using use_framewors or not. As a failsafe, condition, let's always add the `"$(PODS_TARGET_SRCROOT)"` to the search paths to make sure that archiving won't fail. Whe used in other context, that should not be a problem: search paths are just directory Xcode uses to find headers that are needed. Reviewed By: NickGerleman Differential Revision: D54417386
cipolleschi
force-pushed
the
export-D54417386
branch
from
e5c831c to
8e77db3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54417386 |
Summary: When used alone, yoga has no visibility over the USE_FRAMEWORKS variable set by React Native. In this case, there is no other way to know whether the current target that will install the spec is using use_framewors or not. As a failsafe, condition, let's always add the `"$(PODS_TARGET_SRCROOT)"` to the search paths to make sure that archiving won't fail. Whe used in other context, that should not be a problem: search paths are just directory Xcode uses to find headers that are needed. Reviewed By: NickGerleman Differential Revision: D54417386
cipolleschi
force-pushed
the
export-D54417386
branch
from
8e77db3 to
2190073
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54417386 |
|
This pull request has been merged in 363016e. |
NickGerleman
pushed a commit
that referenced
this pull request
Mar 5, 2024
Summary: Pull Request resolved: #1585 When used alone, yoga has no visibility over the USE_FRAMEWORKS variable set by React Native. In this case, there is no other way to know whether the current target that will install the spec is using use_framewors or not. As a failsafe, condition, let's always add the `"$(PODS_TARGET_SRCROOT)"` to the search paths to make sure that archiving won't fail. Whe used in other context, that should not be a problem: search paths are just directory Xcode uses to find headers that are needed. Reviewed By: NickGerleman Differential Revision: D54417386 fbshipit-source-id: aa2ae41c077e4346c0417c73291a37c992a06b58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When used alone, yoga has no visibility over the USE_FRAMEWORKS variable set by React Native.
In this case, there is no other way to know whether the current target that will install the spec is using use_framewors or not. As a failsafe, condition, let's always add the
"$(PODS_TARGET_SRCROOT)"to the search paths to make sure that archiving won't fail.Whe used in other context, that should not be a problem: search paths are just directory Xcode uses to find headers that are needed.
Differential Revision: D54417386