More niche box sizing tests #1712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D63407730
Differential Revision: D63408245
Differential Revision: D63416833
Summary: tsia, add some more advanced tests checking * percent widths/heights/padding/border * absolute positioned nodes with content box * containing block with content box + static * flex basis (fails now, needs follow up) * relative padding/border values All pass but flex basis Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63423302
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D63423302 |
|
This pull request has been merged in bc23694. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
tsia, add some more advanced tests checking
All pass but flex basis
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D63423302