Fix issue where padding is resolved against wrong reference length #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D63787577 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 3, 2024
…rence length (facebook#46799) Summary: X-link: facebook/yoga#1715 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal} Differential Revision: D63787577
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 3, 2024
…rence length (facebook#46799) Summary: X-link: facebook/yoga#1715 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal} Differential Revision: D63787577
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 3, 2024
…rence length (facebook#46799) Summary: X-link: facebook/yoga#1715 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal} Differential Revision: D63787577
joevilches
force-pushed
the
export-D63787577
branch
from
fe6b3a7 to
2b07f5d
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 3, 2024
…rence length (facebook#1715) Summary: X-link: facebook/react-native#46799 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal} Differential Revision: D63787577
|
This pull request was exported from Phabricator. Differential Revision: D63787577 |
…rence length (facebook#1715) Summary: X-link: facebook/react-native#46799 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal} Differential Revision: D63787577
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 4, 2024
…wrong reference length (facebook#46799) Summary: X-link: facebook/yoga#1715 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal} Differential Revision: D63787577
joevilches
force-pushed
the
export-D63787577
branch
from
2b07f5d to
af0523f
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 4, 2024
…rence length (facebook#46799) Summary: X-link: facebook/yoga#1715 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal} Differential Revision: D63787577
|
This pull request was exported from Phabricator. Differential Revision: D63787577 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 5, 2024
…rence length Summary: X-link: facebook/yoga#1715 X-link: facebook/react-native#46799 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63787577 fbshipit-source-id: e512338770f25b66506cabab5a7cde8f04397ea0
|
This pull request has been merged in e69fcb2. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 5, 2024
…rence length (#46799) Summary: X-link: facebook/yoga#1715 Pull Request resolved: #46799 Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height. This just pipes the width into our box sizing functions. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63787577 fbshipit-source-id: e512338770f25b66506cabab5a7cde8f04397ea0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#46799
Content box impl had a bug where we resolved padding % against the same reference length as the dimensions. Padding should always be against containing block's width. This is also true for width, but not for height, which should be against containing block's height.
This just pipes the width into our box sizing functions.
Changelog: [Internal}
Differential Revision: D63787577