Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative value rounding issue for nodes across an axis #688

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix negative value rounding issue for nodes across an axis #688

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70369ae
Fix negative value rounding issue for nodes across an axis
Dec 19, 2017
b50a764
Merge branch 'main' into rounding-nodes-shrink
rozele Jan 24, 2023
d5d05a4
Switch from float to double rounding functions
rozele Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions yoga/Yoga.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3701,16 +3701,12 @@ YOGA_EXPORT float YGRoundValueToPixelGrid(
scaledValue = scaledValue - fractial + 1.0;
} else if (forceCeil) {
// Next we check if we need to use forced rounding
scaledValue = scaledValue - fractial + 1.0;
scaledValue = ceil(scaledValue);
} else if (forceFloor) {
scaledValue = scaledValue - fractial;
scaledValue = floor(scaledValue);
} else {
// Finally we just round the value
scaledValue = scaledValue - fractial +
(!YGDoubleIsUndefined(fractial) &&
(fractial > 0.5 || YGDoubleEqual(fractial, 0.5))
? 1.0
: 0.0);
scaledValue = round(scaledValue);
}
return (YGDoubleIsUndefined(scaledValue) ||
YGDoubleIsUndefined(pointScaleFactor))
Expand Down