Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

support for php-8 #372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support for php-8 #372

wants to merge 1 commit into from

Conversation

jeffochoa
Copy link

Adding support for php8

@facebook-github-bot
Copy link

Hi @jeffochoa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@jeffochoa
Copy link
Author

Hi @jeffochoa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

done!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iLexN
Copy link

iLexN commented Jan 26, 2022

this pull request will merge?

@iLexN iLexN mentioned this pull request Jan 26, 2022
Open
@vincentkoc
Copy link
Contributor

Looks good +1 on review

@mAlkhatieb
Copy link

Looks good

@vincentkoc
Copy link
Contributor

+1

@vincentkoc vincentkoc mentioned this pull request Apr 6, 2022
Open
@lloricode
Copy link

+1

@vladsolntsev
Copy link

vladsolntsev commented Apr 3, 2023 •
edited
Loading

hello @pestevez, any hope that it will be merged soon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeffochoa @facebook-github-bot @iLexN @vincentkoc @mAlkhatieb @lloricode @vladsolntsev