added support for PHP8

[brainexe]

I added support for PHP8, as it's required soonish.
This require some major PHPunit upgrades to version 9.*. This kicks out PHP 7.0 and below (e.g. by needed return typehints).
But there is no PHP7.0 support since years...

[limonte]

@brainexe your PR most probably won't be merged because this repo is not maintained anymore. Would you mind to fork it and publish this change so folks can use your fork with PHP 8?

[jeversen]

@brainexe like @limonte says, it would be great if you could make your fork public so people can use it with PHP8 :)

[brainexe]

sorry, right now I'm not willing to maintain a fork. But feel free to use the current version from https://github.com/brainexe/php-graph-sdk/tree/php8 (you can use it directly or create another fork out of it). I'll keep my version as it is

[nickdnk]

Is Facebook serious with this? Is this not their library?

[spekulatius]

sorry, right now I'm not willing to maintain a fork. But feel free to use the current version from https://github.com/brainexe/php-graph-sdk/tree/php8 (you can use it directly or create another fork out of it). I'll keep my version as it is

Totally understandable. Maintaining a fork of this size isn't something to take lightly. Maybe someone at @facebook is able to get this moving? Sounds like there is plenty of interest in PHP8 for the SDK...

[nickdnk]

I have created a fork of @brainexe 's PHP 8 branch and released it here: https://packagist.org/packages/nickdnk/graph-sdk

I will pull changes from that branch and release it using semantic versioning starting from 6.0.0. I removed all branches and tags from the source repo as Packagist complained about all kinds of things. I am just going to assume that it works and I won't be updating it unless @brainexe does.

I know this is not "best practice" when it comes to re-hosting packages, but since the world's greatest social media platform cannot figure out how to update their PHP library I took the liberty of doing it myself.

Edit: I dropped PHP 7.2 from the release as the tests fail for some reason. So it's >= 7.3: https://travis-ci.com/github/nickdnk/php-graph-sdk

[brainexe]

@nickdnk thx, look fine 👍
I am not planning any further changes as I became a father recently and have less dev time than I had hoped 😅

[nickdnk]

@nickdnk thx, look fine 👍

I am not planning any further changes as I became a father recently and have less dev time than I had hoped 😅

That's fair. Thanks for adjusting it in the first place.