This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
missing-prototypes #312
Open
missing-prototypes #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor @strager had recommended enabling missing-prototypes, which proved us eful for identifying unused code. In addition to missing-prototypes, this will en able -Wall and -Werror for C code.
sas
suggested changes
Jan 8, 2020
add_compile_options() will need CMake generator expressions to distinguish between invocations of C and C++ compilers. This commit did not solve the issue and may cause build errors if the missing-prototypes option is passed to C++ compilers. This reverts commit 45a1357.
Contributor @strager had recommended enabling missing-prototypes, which proved useful for identifying unused code. I have added warning options -Wmissing-declarations and for the C compiler -Wmissing-prototypes. Until these warnings are taken care of, I've disabled errors for these warnings.
sas
suggested changes
Jan 28, 2020
|
If we aren't going to address them then perhaps just disabling this warning entirely on GCC and Clang builds would be appropriate? |
|
Disabling them completely would be fine by me. It's up to you; if you want we can disable them, but if you prefer fixing them and landing the fixes along with the changes that enable the warnings everywhere, then that works too. Forgive me if I asked you this question before but are these warnings enabled by default on certain versions of gcc/clang? If I remember correctly, they are disabled by default and the user needs to enabled them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor @strager had recommended enabling missing-prototypes, which proved useful for identifying unused code. In addition to missing-prototypes in C code, this will enable -Wall and -Werror.