Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding feature engineering unit test cases #1083

Merged
merged 11 commits into from
Oct 23, 2024

Conversation

sumane81
Copy link

@sumane81 sumane81 commented Oct 22, 2024

Project Robyn

Added unit tests for feature engineering.

How Has This Been Tested?

image

Feature engineering code coverage is 74% with tests added in this PR

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2024
@sumane81 sumane81 requested a review from alxlyj October 23, 2024 03:35
Copy link

@dhavalpatel624624 dhavalpatel624624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! #shipit

@sumane81 sumane81 merged commit 2070461 into robynpy_release Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants