-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: feature engineering unit tests #1086
base: robynpy_release
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code coverage is at 70% compared to 74% from earlier tests.
- Can you remove the src folder from the path?
|
||
def setUp(self): | ||
# Create main mocks | ||
self.mmm_data = MagicMock(spec=MMMData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preferred using simulated data than letting unit test mock create high level mock data.
|
||
# Assertions | ||
self.assertIsInstance(result, FeaturizedMMMData) | ||
self.assertTrue(hasattr(result, "dt_mod")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just having the attributes is good enough test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change spec folder name to docs? Also, remove src folder from the path
Project Robyn
Summary
Test Plan