update: feature engineering unit tests #1086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sumane81
requested changes
Oct 24, 2024
There was a problem hiding this comment.
- Code coverage is at 70% compared to 74% from earlier tests.
- Can you remove the src folder from the path?
|
|
||
| def setUp(self): | ||
| # Create main mocks | ||
| self.mmm_data = MagicMock(spec=MMMData) |
There was a problem hiding this comment.
I preferred using simulated data than letting unit test mock create high level mock data.
|
|
||
| # Assertions | ||
| self.assertIsInstance(result, FeaturizedMMMData) | ||
| self.assertTrue(hasattr(result, "dt_mod")) |
There was a problem hiding this comment.
Just having the attributes is good enough test?
There was a problem hiding this comment.
can you change spec folder name to docs? Also, remove src folder from the path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
Summary
Test Plan