-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster builder interface and updated output #1089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments primarily on namings and refactoring for visualization. we can look into getting rid of the older clustering interfaces in our next iteration.
I asked AI to review the code for me. I'll review cluster_builder.py and clustering_results.py focusing on code structure, encapsulation, type safety and proper initialization. Let me analyze each file and suggest improvements. First, let's examine clustering_results.py: Key improvements to clustering_results.py:
Now let's examine cluster_builder.py. This class has multiple responsibilities and should be split up: Key improvements to cluster_builder.py:
The refactored code is now:
Attached refactored code. Change .MD extension to .py Review refactored code and use whatever is applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Project Robyn
Generated cluster builder interface which will cluster models and updated the clustering_result dataclass for outputs
No testing needed at this point