Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update modeling column discrepancies #1170

Draft
wants to merge 4 commits into
base: robynpy_release
Choose a base branch
from
Draft

update modeling column discrepancies #1170

wants to merge 4 commits into from

Conversation

alxlyj
Copy link
Contributor

@alxlyj alxlyj commented Dec 3, 2024 •
edited
Loading

Project Robyn

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Summary

  • Modeling
    • Fixed column discrepancy [i.e. "ds" column].
    • The other metrics (NRMSE, RSQ) are very close between R and Python
    • The lambda_max values match well
    • The lambda values are now in a much more reasonable range
  • Pareto
  • Visuals
  • Allocator

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxlyj @facebook-github-bot