Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React warnings/errors. #831

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

zpao
Copy link
Contributor

@zpao zpao commented Oct 4, 2023

This fixes warnings/errors that React is outputting.

  1. title was an object, so the same key was being set for all elements. There's no need to use JSX for that since you're rendering an <h3> anyway, so easy win.
  2. <ul> isn't a valid DOM child of <p> so rendering engines actually move DOM nodes around to make it work, which can break React. Use a <div> instead (and remove extra React fragment wrapping).
  3. Properly case some attributes on <iframe>s

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2023
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you so much!

@gufengzhou gufengzhou merged commit 2c3d814 into facebookexperimental:main Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants