Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup script and dev instructions in README #3

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

huntie
Copy link

@huntie huntie commented Dec 4, 2023

Summary

Adds a setup script and README guidance for initially working with the repo.

Test plan

setup.sh — automated initial setup flow

image

✅ Succeeds and places shell in migrated project dir

setup.sh — subsequent runs

image

✅ Prevents further changes

Build

image

✅ Succeeds using suite of package.json scripts

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

Copy link

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice-job

@huntie huntie requested a review from motiz88 December 14, 2023 12:45
@hoxyq
Copy link

hoxyq commented Jan 15, 2024

nit: maybe we should add removing the original directory of the project after the setup, because its empty at this stage

@huntie huntie merged commit 3b3ac6c into facebookexperimental:main Jan 15, 2024
3 checks passed
@huntie huntie deleted the setup-script branch January 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants