[fuse_elementwise] Fix external outputs collection #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has multiple external outputs with different shapes
facebook-github-bot
added
the
CLA Signed
ymwangg
commented
Jul 26, 2023
| """ | ||
| Given an elementwise op, returns a list of parent elementwise ops | ||
| which can be fused with this elementwise op. | ||
| """ | ||
|
|
||
| # Get parent ops. | ||
| dependent_ops = set() | ||
| for input_tensor in op._attrs["inputs"]: | ||
| for input_tensor in src_op._attrs["inputs"]: |
There was a problem hiding this comment.
This is to avoid a naming collision to make debug easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a corner case where the
fuse_elementwisepass may produce two external output tensors with different shapes. This subgraph pattern is seen the huggingface bert model.