Mccloskey/llama2 hf #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bator/CP4M into mccloskey/llama2-hf
hunterjackson
requested changes
Oct 31, 2023
| public T handle(ThreadState<T> messageStack) throws IOException { | ||
| T fromUser = messageStack.tail(); | ||
| @Override | ||
| public T handle(ThreadState<T> threadState) throws IOException { |
| HuggingFaceLlamaPromptBuilder<T> promptBuilder = new HuggingFaceLlamaPromptBuilder<>(); | ||
|
|
||
| String prompt = promptBuilder.createPrompt(threadState, config); | ||
| if (prompt.equals("I'm sorry but that request was too long for me.")) { |
There was a problem hiding this comment.
just have createPrompt return an Optional instead of doing string check like this
|
|
||
| body.put("inputs", prompt); | ||
|
|
||
| String bodyString; | ||
| try { | ||
| bodyString = MAPPER.writeValueAsString(body); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException(e); // this should be impossible | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
just add a comment saying this should be impossible
| try { | ||
| resource = Objects.requireNonNull(HuggingFaceLlamaPromptBuilder.class.getClassLoader().getResource("llamaTokenizer.json")).toURI(); | ||
| } catch (URISyntaxException e) { | ||
| LOGGER.error("Failed to find local llama tokenizer.json file", e); |
There was a problem hiding this comment.
this is a fatal error, lets throw an exception. Continuing on after a fatal error is a great way to get unexpected input downstream
Suggested change
| LOGGER.error("Failed to find local llama tokenizer.json file", e); | |
| LOGGER.error("Failed to find local llama tokenizer.json file", e); | |
| throw new RuntimeException(e); |
| } | ||
|
|
||
| try { | ||
| assert resource != null; |
There was a problem hiding this comment.
assert in java only runs in unit test (I know it's weird), that's why we have Objects.requiresNonNull()
| Identifier.random(), | ||
| Identifier.random(), | ||
| Message.Role.SYSTEM); | ||
| ArrayList<Message> output = new ArrayList<>(); |
There was a problem hiding this comment.
is there a way we can avoid creating a intermediary list object here? If not lets at least initiate the size of the array list because we know that.
hunterjackson
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.