Add Instagram Direct Message handling #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IG needs to be sent to the messaging parent (FB) page ID instead of the IG ID, but the webhook contains the IG ID, so for now we default to sending to me/messages which infers the right page from the Access Token
| @@ -44,6 +44,7 @@ public class FBMessageHandler implements MessageHandler<FBMessage> { | |||
| private final String appSecret; | |||
|
|
|||
| private final String accessToken; | |||
| private final Boolean isInstagram; | |||
There was a problem hiding this comment.
in general you want to use primitives bool where possible because it is not possible for them to be null
| @@ -44,6 +44,7 @@ public class FBMessageHandler implements MessageHandler<FBMessage> { | |||
| private final String appSecret; | |||
|
|
|||
| private final String accessToken; | |||
| @Nullable private final String connectedFacebookPageForInstagram; | |||
There was a problem hiding this comment.
Suggested change
| @Nullable private final String connectedFacebookPageForInstagram; | |
| private final @Nullable String connectedFacebookPageForInstagram; |
This just keeps the reformatting from adding a newline
| @@ -10,60 +10,77 @@ | |||
|
|
|||
| import com.fasterxml.jackson.annotation.JsonProperty; | |||
| import com.google.common.base.Preconditions; | |||
| import org.jetbrains.annotations.Nullable; | |||
There was a problem hiding this comment.
wrong Nullable, you want the Nullable from the checker framework
Comment on lines
83
to
84
| public String connectedFacebookPageForInstagram() { | ||
| return connectedFacebookPageForInstagram; |
There was a problem hiding this comment.
Suggested change
| public String connectedFacebookPageForInstagram() { | |
| return connectedFacebookPageForInstagram; | |
| public Optional<String> connectedFacebookPageForInstagram() { | |
| return Optional.ofNullable(connectedFacebookPageForInstagram); |
pretty sure this the right code, but you want a return an Optional where possible for nullable values from functions
Comment on lines
24
to
25
| @Nullable | ||
| private final String connectedFacebookPageForInstagram; |
There was a problem hiding this comment.
Suggested change
| @Nullable | |
| private final String connectedFacebookPageForInstagram; | |
| private final @Nullable String connectedFacebookPageForInstagram; |
:)
| return pageAccessToken; | ||
| } | ||
|
|
||
| public @Nullable Optional<String> connectedFacebookPageForInstagram() { |
There was a problem hiding this comment.
Suggested change
| public @Nullable Optional<String> connectedFacebookPageForInstagram() { | |
| public Optional<String> connectedFacebookPageForInstagram() { |
hunterjackson
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to handle instagram webhooks into the Facebook Message Handler - major differences are the FB page ID must be used for the call and message echos (notifs when the page sends a message) are sent along with messages, not a separate webhook subscription