Do not modify sys.modules, move __version__ into __init__.py

[frenzymadness]

I honestly don't think that the manual modification of sys.modules is a good idea and it might be even worst if you switch an imported module with a string. This way, it works fine also with older setuptools where it's not possible to load the script without importing the module.

There are more possible solutions so feel free to let me know if you don't like this one.

[facebook-github-bot]

Hi @frenzymadness!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[frenzymadness]

This change needs the workaround to be removed from the specfile to build again. Also, I've asked Red Hat whether I can sign the CLA or not and I hope that it won't take long.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!