Skip to content

Commit

Permalink
Move session_cache_ResumptionSuccess probe to validateResumptionState
Browse files Browse the repository at this point in the history
Summary: The `session_cache_ResumptionSuccess` probe is in the wrong location. Let's move this to validateResumptionSuccess.

Reviewed By: mingtaoy

Differential Revision: D63327282

fbshipit-source-id: 76c5d27bdcefda07030b1a0f1a2e27a7c7c83110
  • Loading branch information
Nick Richardson authored and facebook-github-bot committed Nov 15, 2024
1 parent 25e33a7 commit 7db6343
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fizz/server/ServerProtocol.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,6 @@ static ResumptionStateResult getResumptionState(
return ResumptionStateResult(
std::make_pair(PskType::Rejected, folly::none));
} else {
FOLLY_SDT(fizz, session_cache_ResumptionSuccess);
const auto& ident = psks->identities[kPskIndex].psk_identity;
return ResumptionStateResult(
ticketCipher->decrypt(ident->clone()),
Expand Down Expand Up @@ -1319,6 +1318,8 @@ EventHandler<ServerTypes, StateEnum::ExpectingClientHello, Event::ClientHello>::
pskType = PskType::Rejected;
pskMode = folly::none;
resState = folly::none;
} else {
FOLLY_SDT(fizz, session_cache_ResumptionSuccess);
}
} else {
pskMode = folly::none;
Expand Down

0 comments on commit 7db6343

Please sign in to comment.