Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramatized rust_static_library to enable CXX support #205

Closed
wants to merge 1 commit into from

Conversation

jdelliot
Copy link
Contributor

Summary:
X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, USE_CXX_INCLUDE, to the CMake function, rust_static_library, to enable adding the cxxbridge path to the include path.

Differential Revision: D50772544

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Oct 29, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50772544

jdelliot pushed a commit to jdelliot/hsthrift that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/rust-shed that referenced this pull request Oct 29, 2023
…mental#43)

Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763


X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fb303 that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092


X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fizz that referenced this pull request Oct 29, 2023
…tor#101)

Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205


X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/katran that referenced this pull request Oct 29, 2023
…tor#205)

Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3


X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/openr that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221


X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/folly that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403


X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/watchman that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/edencommon that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fboss that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/hhvm that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150


X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/sapling that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101


X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/mvfst that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/proxygen that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/wangle that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43


X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fbthrift that referenced this pull request Oct 29, 2023
Summary:
X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Differential Revision: D50772544
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50772544

…tor#205)

Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3


X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/watchman that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/wangle that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43


X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/openr that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221


X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fizz that referenced this pull request Oct 30, 2023
…tor#101)

Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205


X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/hhvm that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150


X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/mvfst that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/rust-shed that referenced this pull request Oct 30, 2023
…mental#43)

Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763


X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/sapling that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101


X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/edencommon that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fbthrift that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/hsthrift that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fb303 that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092


X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/fboss that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/folly that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403


X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
jdelliot pushed a commit to jdelliot/proxygen that referenced this pull request Oct 30, 2023
Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50772544

facebook-github-bot pushed a commit to facebook/wangle that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

Pull Request resolved: #221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebookexperimental/edencommon that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/fboss that referenced this pull request Oct 30, 2023
Summary:
Pull Request resolved: #161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/proxygen that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

Pull Request resolved: #43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/fb303 that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

Pull Request resolved: #42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebookincubator/hsthrift that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/fbthrift that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/mvfst that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

Pull Request resolved: #763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebookincubator/fizz that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

Pull Request resolved: #101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/folly that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

Pull Request resolved: #2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f12ad6d.

facebook-github-bot pushed a commit to facebookincubator/velox that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

Pull Request resolved: #7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/watchman that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/hhvm that referenced this pull request Nov 6, 2023
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

Pull Request resolved: #9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot pushed a commit to facebook/openr that referenced this pull request Jan 9, 2024
Summary:
X-link: facebook/fboss#161

X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

Pull Request resolved: #150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544

fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants