Revert D66724539: refactor: Use KeepAlive instead of Executor*

Differential Revision:
D66724539

Original commit changeset: 231527346bdd

Original Phabricator Diff: D66724539

fbshipit-source-id: a239159cc880400a3ef4650ad842f43331ac5d73

dwio/nimble/tablet/tests/TabletTests.cpp

@@ -553,7 +553,7 @@ TEST(TabletTests, OptionalSections) {
 
   tabletWriter.close();
 
-  auto executor = std::make_shared<folly::CPUThreadPoolExecutor>(5);
+  folly::CPUThreadPoolExecutor executor{5};
   facebook::velox::dwio::common::ExecutorBarrier barrier{executor};
 
   for (auto useChaniedBuffers : {false, true}) {
@@ -914,7 +914,7 @@ TEST(TabletTests, ReferenceCountedCacheStressParallelDuplicates) {
     ++counter;
     return std::make_shared<int>(id);
   }};
-  auto executor = std::make_shared<folly::CPUThreadPoolExecutor>(10);
+  folly::CPUThreadPoolExecutor executor(10);
   velox::dwio::common::ExecutorBarrier barrier(executor);
   constexpr int kEntryIds = 100;
   constexpr int kEntryDuplicates = 10;
@@ -937,7 +937,7 @@ TEST(TabletTests, ReferenceCountedCacheStressParallelDuplicatesSaveEntries) {
     return std::make_shared<int>(id);
   }};
   folly::Synchronized<std::vector<std::shared_ptr<int>>> entries;
-  auto executor = std::make_shared<folly::CPUThreadPoolExecutor>(10);
+  folly::CPUThreadPoolExecutor executor(10);
   velox::dwio::common::ExecutorBarrier barrier(executor);
   constexpr int kEntryIds = 100;
   constexpr int kEntryDuplicates = 10;
@@ -960,7 +960,7 @@ TEST(TabletTests, ReferenceCountedCacheStress) {
     ++counter;
     return std::make_shared<int>(id);
   }};
-  auto executor = std::make_shared<folly::CPUThreadPoolExecutor>(10);
+  folly::CPUThreadPoolExecutor executor(10);
   velox::dwio::common::ExecutorBarrier barrier(executor);
   constexpr int kEntryIds = 100;
   constexpr int kEntryDuplicates = 10;
@@ -982,7 +982,7 @@ TEST(TabletTests, ReferenceCountedCacheStressSaveEntries) {
     return std::make_shared<int>(id);
   }};
   folly::Synchronized<std::vector<std::shared_ptr<int>>> entries;
-  auto executor = std::make_shared<folly::CPUThreadPoolExecutor>(10);
+  folly::CPUThreadPoolExecutor executor(10);
   velox::dwio::common::ExecutorBarrier barrier(executor);
   constexpr int kEntryIds = 100;
   constexpr int kEntryDuplicates = 10;