-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
6 changed files
with
175 additions
and
159 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| /* | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #pragma once | ||
|
|
||
| #include "folly/container/F14Set.h" | ||
| #include "velox/functions/Udf.h" | ||
|
|
||
| namespace facebook::velox::functions::sparksql { | ||
|
|
||
| template <typename TExecCtx> | ||
| struct StringToMapFunction { | ||
| VELOX_DEFINE_FUNCTION_TYPES(TExecCtx); | ||
|
|
||
| // Results refer to strings in the first argument. | ||
| static constexpr int32_t reuse_strings_from_arg = 0; | ||
|
|
||
| void call( | ||
| out_type<Map<Varchar, Varchar>>& out, | ||
| const arg_type<Varchar>& input, | ||
| const arg_type<Varchar>& entryDelimiter, | ||
| const arg_type<Varchar>& keyValueDelimiter) { | ||
| VELOX_USER_CHECK(!entryDelimiter.empty(), "entryDelimiter is empty"); | ||
| VELOX_USER_CHECK(!keyValueDelimiter.empty(), "keyValueDelimiter is empty"); | ||
|
|
||
| callImpl( | ||
| out, | ||
| toStringView(input), | ||
| toStringView(entryDelimiter), | ||
| toStringView(keyValueDelimiter)); | ||
| } | ||
|
|
||
| private: | ||
| static std::string_view toStringView(const arg_type<Varchar>& input) { | ||
| return std::string_view(input.data(), input.size()); | ||
| } | ||
|
|
||
| void callImpl( | ||
| out_type<Map<Varchar, Varchar>>& out, | ||
| std::string_view input, | ||
| std::string_view entryDelimiter, | ||
| std::string_view keyValueDelimiter) const { | ||
| size_t pos = 0; | ||
|
|
||
| folly::F14FastSet<std::string_view> keys; | ||
|
|
||
| auto nextEntryPos = input.find(entryDelimiter, pos); | ||
| while (nextEntryPos != std::string::npos) { | ||
| processEntry( | ||
| out, | ||
| std::string_view(input.data() + pos, nextEntryPos - pos), | ||
| keyValueDelimiter, | ||
| keys); | ||
|
|
||
| pos = nextEntryPos + 1; | ||
| nextEntryPos = input.find(entryDelimiter, pos); | ||
| } | ||
|
|
||
| processEntry( | ||
| out, | ||
| std::string_view(input.data() + pos, input.size() - pos), | ||
| keyValueDelimiter, | ||
| keys); | ||
| } | ||
|
|
||
| void processEntry( | ||
| out_type<Map<Varchar, Varchar>>& out, | ||
| std::string_view entry, | ||
| std::string_view keyValueDelimiter, | ||
| folly::F14FastSet<std::string_view>& keys) const { | ||
| const auto delimiterPos = entry.find(keyValueDelimiter, 0); | ||
| // Not found key/value delimiter. | ||
| if (delimiterPos == std::string::npos) { | ||
| out.add_null().append(StringView(entry)); | ||
| return; | ||
| } | ||
| const auto key = std::string_view(entry.data(), delimiterPos); | ||
| VELOX_USER_CHECK( | ||
| keys.insert(key).second, | ||
| "Duplicate keys are not allowed: ('{}').", | ||
| key); | ||
| const auto value = StringView( | ||
| entry.data() + delimiterPos + 1, entry.size() - delimiterPos - 1); | ||
|
|
||
| auto [keyWriter, valueWriter] = out.add_item(); | ||
| keyWriter.setNoCopy(StringView(key)); | ||
| valueWriter.setNoCopy(value); | ||
| } | ||
| }; | ||
|
|
||
| } // namespace facebook::velox::functions::sparksql |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #include "velox/common/base/tests/GTestUtils.h" | ||
| #include "velox/functions/sparksql/tests/SparkFunctionBaseTest.h" | ||
| #include "velox/type/Type.h" | ||
|
|
||
| namespace facebook::velox::functions::sparksql::test { | ||
| using namespace facebook::velox::test; | ||
| namespace { | ||
| class StringToMapTest : public SparkFunctionBaseTest { | ||
| protected: | ||
| void testStringToMap( | ||
| const std::vector<StringView>& inputs, | ||
| const std::vector<std::pair<StringView, std::optional<StringView>>>& | ||
| expect) { | ||
| std::vector<VectorPtr> row; | ||
| row.emplace_back(makeFlatVector<StringView>({inputs[0]})); | ||
| std::string expr = | ||
| fmt::format("str_to_map(c0, '{}', '{}')", inputs[1], inputs[2]); | ||
| auto result = evaluate<MapVector>(expr, makeRowVector(row)); | ||
| auto expected = makeMapVector<StringView, StringView>({expect}); | ||
| assertEqualVectors(result, expected); | ||
| } | ||
| }; | ||
|
|
||
| TEST_F(StringToMapTest, Basics) { | ||
| testStringToMap( | ||
| {"a:1,b:2,c:3", ",", ":"}, {{"a", "1"}, {"b", "2"}, {"c", "3"}}); | ||
| testStringToMap({"a: ,b:2", ",", ":"}, {{"a", " "}, {"b", "2"}}); | ||
| testStringToMap({"", ",", ":"}, {{"", std::nullopt}}); | ||
| testStringToMap({"a", ",", ":"}, {{"a", std::nullopt}}); | ||
| testStringToMap( | ||
| {"a=1,b=2,c=3", ",", "="}, {{"a", "1"}, {"b", "2"}, {"c", "3"}}); | ||
| testStringToMap({"", ",", "="}, {{"", std::nullopt}}); | ||
| testStringToMap( | ||
| {"a::1,b::2,c::3", ",", "c"}, | ||
| {{"", "::3"}, {"a::1", std::nullopt}, {"b::2", std::nullopt}}); | ||
| testStringToMap( | ||
| {"a:1_b:2_c:3", "_", ":"}, {{"a", "1"}, {"b", "2"}, {"c", "3"}}); | ||
| // Same delimiters. | ||
| testStringToMap( | ||
| {"a:1_b:2_c:3", "_", "_"}, | ||
| {{"a:1", std::nullopt}, {"b:2", std::nullopt}, {"c:3", std::nullopt}}); | ||
| // Exception for duplicated keys. | ||
| VELOX_ASSERT_THROW( | ||
| testStringToMap({"a:1,b:2,a:3", ",", ":"}, {{"a", "3"}, {"b", "2"}}), | ||
| "Duplicate keys are not allowed: ('a')."); | ||
| } | ||
| } // namespace | ||
| } // namespace facebook::velox::functions::sparksql::test |